-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KeyboardDragListener doesn't interrupt on blur #1285
Comments
Fixed in the above commit, @zepumph is this change OK with you? |
I can't think of any reason that would be bad. Thanks! |
Similar to this, I just saw that interrupt doesn't call |
Ran into this over in phetsims/my-solar-system#86 |
Spot check from @jessegreenberg, I basically copied the idea from scenery/js/listeners/PressListener.ts Lines 547 to 551 in 80e2985
|
This change makes sense, thank you! Looking for other cases like phetsims/friction#342, but I didn't see anything else. Closing. |
I noticed that the KeyboardDragListener doesn't interrupt itself on blur which is surprising to me. I am using one without a GrabDragInteraction in quadrilateral and tabbing away from the Node while movement keys are down result in the pressed keys staying in the
keyState
array. This isn't a problem for GrabDragInteraction because of these lineshttps://github.com/phetsims/scenery-phet/blob/03097363295d48e5be248c9ecbbbf29853799625/js/accessibility/GrabDragInteraction.js#L654-L665
The text was updated successfully, but these errors were encountered: