TypeScript conversion for Panel, ComboBox (and assorted types), see p…

…hetsims/scenery-phet#726
phetsims · Mar 5, 2022 · 6f77774 · 6f77774
1 parent 2e9eb77
commit 6f77774
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 7 deletions.
diff --git a/js/accessibility/pdom/AriaHasPopUpMutator.js → js/accessibility/pdom/AriaHasPopUpMutator.ts b/js/accessibility/pdom/AriaHasPopUpMutator.js → js/accessibility/pdom/AriaHasPopUpMutator.ts
@@ -10,16 +10,15 @@
  *
  * @author Jesse Greenberg
  */
-import { scenery } from '../../imports.js';
+import { scenery, Node } from '../../imports.js';
 
 const AriaHasPopUpMutator = {
 
   /**
-   * @public
-   * @param {Node} node - Node whose ParallelDOM.js fields will change
-   * @param {boolean|string} value - Valid value for aria-haspopup attribute, or false to remove the attribute
+   * @param node - Node whose ParallelDOM.js fields will change
+   * @param value - Valid value for aria-haspopup attribute, or false to remove the attribute
    */
-  mutateNode( node, value ) {
+  mutateNode( node: Node, value: boolean | string ) {
     if ( value ) {
       node.setPDOMAttribute( 'aria-haspopup', value );
     }

diff --git a/js/accessibility/voicing/Voicing.ts b/js/accessibility/voicing/Voicing.ts
@@ -83,7 +83,7 @@ type VoicingSelfOptions = {
 
 type VoicingOptions = VoicingSelfOptions & InteractiveHighlightingOptions;
 
-type SpeakingOptions = {
+export type SpeakingOptions = {
   utterance?: VoicingSelfOptions['voicingUtterance']
 } & {
 

diff --git a/js/imports.ts b/js/imports.ts
@@ -161,7 +161,7 @@ export type { InteractiveHighlightingOptions } from './accessibility/voicing/Int
 export { default as voicingManager } from './accessibility/voicing/voicingManager.js';
 export { default as voicingUtteranceQueue } from './accessibility/voicing/voicingUtteranceQueue.js';
 export { default as Voicing } from './accessibility/voicing/Voicing.js';
-export type { VoicingOptions } from './accessibility/voicing/Voicing.js';
+export type { VoicingOptions, SpeakingOptions } from './accessibility/voicing/Voicing.js';
 export { default as ReadingBlockUtterance } from './accessibility/voicing/ReadingBlockUtterance.js';
 export { default as FocusDisplayedController } from './accessibility/FocusDisplayedController.js';
 export { default as FocusManager } from './accessibility/FocusManager.js';