-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add KeyboardDragListeners to MeasuringTapeNode #798
Comments
I think it would be nice for @jessegreenberg to review this. The conversion was pretty straight forward. The worst part was that I know that the DragListener is using a bit of an old pattern for supporting dragging, and it wasn't very plug and play to convert it to use positionProperty + offset + transform + dragBoundsProperty settings. Thus, the options passed to DragListener and KeyboardDragListener aren't very aligned. Is there anything else you see? |
Changes to MeasuringTapeNode and KeyboardDragListener look right to me, thanks! If the intent for keyboard input is "smooth" dragging, can we use the velocity options of KeyboardDragListener? I regret the default value of |
I like it! Thanks so much. |
|
Over in phetsims/my-solar-system#86 it seemed worth a bit of exploration. Seems like the hardest part is just reusing the same code efficiently between dragListener and keyboardDragListener.
The text was updated successfully, but these errors were encountered: