-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Voicing to NumberPicker #725
Comments
Implemented above. @jessegreenberg this was pretty straightforward, would you mind reviewing and seeing if GFLB still looks good to you. |
@zepumph, I just noticed that Mass Control number pickers on master are no longer getting context responses when context responses are checked in preferences. In the published version, GFLB's Number Pickers do get context responses, so maybe some changes here need a second look? |
@terracoda, I made phetsims/gravity-force-lab-basics#320 to fix the issues I made in GFLB. Anything else to change in common code for NumberPicker? |
Oops, missed this issue. I'll review the work very soon. |
The Mass number pickers in GFLB and the Left and Right Value number pickers in RaP are working well, and seem to be working in the exact same way as well. The reading blocks are different, but that is intentional. The Mass Control reading blocks in GFLB are not keyboard accessible (this is intentional) whereas the Current Challenge reading block is keyboard accessible (this is intentional). |
Assuming I can close this issue as Voicing for NumberPicker seems very nice. |
Since this extends AccessibleValueHandler (and therefore voicing), it isn't clear how related this will be to phetsims/sun#730.
It will support phetsims/ratio-and-proportion#441 though.
The text was updated successfully, but these errors were encountered: