-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better names for keyboard-help section classes? #714
Comments
Yes, this sounds good. The title for the general section used to be called "General Navigation" but it changed to "Basic Actions" and we didn't update the class name. Ill rename these. |
…nsKeyboardHelpContent.js, see phetsims/scenery-phet#714
…nsKeyboardHelpContent.js, see phetsims/scenery-phet#714
…nsKeyboardHelpContent.js, see #714
…nsKeyboardHelpContent.js, see phetsims/scenery-phet#714
OK, I renamed GeneralKeyboardHelpSection -> BasicActionsKeyboardHelpSection The rest of the names seem appropriate to me, reassigning to @pixelzoom in case there is anything else. |
Thanks for the quick turnaround on this, it will definitely make things easier going forward. It looks like you hadn't done a pull-all before renaming, because this broke Geometric Optics. Fixed in the above commit. Everything else looks good, closing. |
PhET convention is name things based on how they appear on the screen when possible. This makes it easier to locate code.
Would it be possible to rename the predefined keyboard-help sections so that their titles match their class names? That would make it a lot easier to find what I need, and to understand code that I'm not familiar with.
Some examples...
The text was updated successfully, but these errors were encountered: