initialize at declaration when possible, #404

phetsims · Aug 11, 2022 · 1955c45 · 1955c45
1 parent 8998a89
commit 1955c45
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 12 deletions.
diff --git a/js/common/view/RAPTickMarkLabelsNode.ts b/js/common/view/RAPTickMarkLabelsNode.ts
@@ -21,18 +21,17 @@ const LABEL_X = 0;
 class RAPTickMarkLabelsNode extends Node {
 
   private totalHeight: number;
-  private heightOfText: number | null;
+  private heightOfText: number | null = null;
   private tickMarkViewProperty: EnumerationProperty<TickMarkView>;
   private tickMarkRangeProperty: Property<number>;
   private colorProperty: TReadOnlyProperty<Color | string>;
 
   public constructor( tickMarkViewProperty: EnumerationProperty<TickMarkView>, tickMarkRangeProperty: Property<number>, height: number,
-               colorProperty: TReadOnlyProperty<Color | string>, options?: StrictOmit<NodeOptions, 'children'> ) {
+                      colorProperty: TReadOnlyProperty<Color | string>, options?: StrictOmit<NodeOptions, 'children'> ) {
 
     super();
 
     this.totalHeight = height;
-    this.heightOfText = null;
     this.tickMarkViewProperty = tickMarkViewProperty;
     this.tickMarkRangeProperty = tickMarkRangeProperty;
     this.colorProperty = colorProperty;
@@ -52,7 +51,6 @@ class RAPTickMarkLabelsNode extends Node {
   }
 
   public layout( height: number ): void {
-
     this.totalHeight = height;
     this.update( this.tickMarkRangeProperty.value, this.tickMarkViewProperty.value );
   }

diff --git a/js/common/view/mediaPipeOptions.ts b/js/common/view/mediaPipeOptions.ts
@@ -6,17 +6,11 @@
  */
 
 import BooleanProperty from '../../../../axon/js/BooleanProperty.js';
-import Property from '../../../../axon/js/Property.js';
 import ratioAndProportion from '../../ratioAndProportion.js';
 
 class MediaPipeOptions {
-  public xAxisFlippedProperty: Property<boolean>;
-  public yAxisFlippedProperty: Property<boolean>;
-
-  public constructor() {
-    this.xAxisFlippedProperty = new BooleanProperty( false );
-    this.yAxisFlippedProperty = new BooleanProperty( false );
-  }
+  public xAxisFlippedProperty = new BooleanProperty( false );
+  public yAxisFlippedProperty = new BooleanProperty( false );
 }
 
 const mediaPipeOptions = new MediaPipeOptions();