manually dispose KeyboardHelpSectionRows, phetsims/scenery-phet#769

phetsims · Apr 4, 2023 · daeab1d · daeab1d
1 parent 3852406
commit daeab1d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/js/quadrilateral/view/MoveShapeHelpSection.ts b/js/quadrilateral/view/MoveShapeHelpSection.ts
@@ -52,7 +52,10 @@ export default class MoveShapeHelpSection extends KeyboardHelpSection {
       }
     );
 
-    super( moveCornersOrSidesStringProperty, [ basicMovementRow, fineMovementRow ] );
+    const rows = [ basicMovementRow, fineMovementRow ];
+    super( moveCornersOrSidesStringProperty, rows );
+    this.disposeEmitter.addListener( () => rows.forEach( row => row.dispose() ) );
+
   }
 }
 

diff --git a/js/quadrilateral/view/ShapeShortcutsHelpSection.ts b/js/quadrilateral/view/ShapeShortcutsHelpSection.ts
@@ -57,13 +57,14 @@ export default class ShapeShortcutsHelpSection extends KeyboardHelpSection {
       }
     );
 
-    const contents = [];
+    const contents: KeyboardHelpSectionRow[] = [];
     if ( voicingManager.initialized ) {
       contents.push( checkShapeRow );
     }
     contents.push( resetShapeRow );
 
     super( QuadrilateralStrings.keyboardHelpDialog.shapeShortcutsStringProperty, contents );
+    this.disposeEmitter.addListener( () => contents.forEach( row => row.dispose() ) );
   }
 }