Skip to content

Commit

Permalink
address review comments by creating an issue in tambo, see #398 and p…
Browse files Browse the repository at this point in the history
  • Loading branch information
jessegreenberg committed Mar 21, 2023
1 parent a251107 commit 2c20c44
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions js/quadrilateral/view/sound/TracksSoundView.ts
Original file line number Diff line number Diff line change
Expand Up @@ -149,9 +149,6 @@ export default class TracksSoundView extends SoundGenerator {
* @param dt - in seconds
*/
public step( dt: number ): void {

// REVIEW: It is surprising that we have to do this here in sim-specific code, and not in the sound manager.
// REVIEW: Open a tambo issue to see if this can be handled in the sound manager?
if ( this.playingState === PlayingState.STOPPED ) {
if ( this.outputLevel !== 0 ) {
this.setOutputLevel( 0 );
Expand Down

0 comments on commit 2c20c44

Please sign in to comment.