-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spot check screen reader support #1093
Comments
@jessegreenberg mobileVO is pretty broken right now. The changes you had made in phetsims/utterance-queue#117 were not implemented in #1092 so I have no direct comparison to make. |
Oh good point, thanks. If it is broken in main, that is an issue. I think the main thing to check for is that you can still interact with things. My change has the largets chance of breaking input. So to test, make sure you can double tap on buttons to click them, swipe to use sliders, and so on. For the alerts, as long as it is working like we discussed in phetsims/utterance-queue#117 (comment), it is OK. |
mobileVO calls radio buttons checkboxes AND radio buttons but I think that might have been happening prior to your changes. |
OK, thanks - I will take a look at that. |
I am seeing that too with with iOS 17.5.1 in a very basic example outside of a PhET sim (https://htmlpreview.github.io/?https://github.com/phetsims/a11y-research/blob/main/reader-intro.html), so that is just how VoiceOver does it. Ill add that to the list of accessibility bugs. |
QA is done |
Great, thank you @KatieWoe and @Nancy-Salpepi! |
It would be helpful to make sure that phetsims/scenery#1141 hasn't broken any screen reader access. Can you please briefly test greenhouse-effect on main for each of these?
Hopefully it doesn't take more than 5 minutes per device, I just want to make sure that input isn't obviously broken and behaves as it did in #1092.
This is not urgent, for whenever you have a moment.
Thanks!
The text was updated successfully, but these errors were encountered: