Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on SHRED/Particle #63

Closed
zepumph opened this issue Jan 3, 2024 · 5 comments
Closed

Remove dependency on SHRED/Particle #63

zepumph opened this issue Jan 3, 2024 · 5 comments

Comments

@zepumph
Copy link
Member

zepumph commented Jan 3, 2024

In phetsims/shred#38 I added this for type checking, but it should be more general than this, and it causes trouble if you lint phetcommon without shred checked out.

@jonathanolson and I spoke and we may want to MR all sims published with this since it was added in ce0920e. (8/1/23).

@zepumph
Copy link
Member Author

zepumph commented Jan 3, 2024

The MR is worth it because this is likely the only lint error in all of our release branches, and so it is worth supporting lint for them generally.

@zepumph
Copy link
Member Author

zepumph commented Jan 4, 2024

Ok, the fix has been applied to main. I have not started any patching of release branches, but will likely hit all release branches since 8/1. It will hit even unpublished sims.

@zepumph
Copy link
Member Author

zepumph commented Jan 4, 2024

This is the list I found that needs the patch to lint on release branches:

 acid-base-solutions 1.3 phet,phet-io
        build-a-nucleus 1.1 phet
        center-and-variability 1.1 phet,phet-io
        energy-skate-park 1.3 phet
        greenhouse-effect 1.2 phet,phet-io
        keplers-laws 1.1 phet
        my-solar-system 1.3 phet,phet-io
        natural-selection 1.5 phet,phet-io
        number-line-distance 1.1 phet
        number-line-integers 1.2 phet
        number-line-operations 1.1 phet
        sound-waves 1.1 phet

That said, BAN isn't needed, since it has shred checked out, so I'll skip that one.

zepumph added a commit that referenced this issue Jan 4, 2024
zepumph added a commit to phetsims/acid-base-solutions that referenced this issue Jan 4, 2024
zepumph added a commit that referenced this issue Jan 4, 2024
zepumph added a commit to phetsims/center-and-variability that referenced this issue Jan 4, 2024
zepumph added a commit that referenced this issue Jan 4, 2024
zepumph added a commit to phetsims/energy-skate-park that referenced this issue Jan 4, 2024
zepumph added a commit that referenced this issue Jan 4, 2024
zepumph added a commit to phetsims/greenhouse-effect that referenced this issue Jan 4, 2024
zepumph added a commit that referenced this issue Jan 4, 2024
zepumph added a commit to phetsims/keplers-laws that referenced this issue Jan 4, 2024
zepumph added a commit that referenced this issue Jan 4, 2024
zepumph added a commit to phetsims/my-solar-system that referenced this issue Jan 4, 2024
zepumph added a commit that referenced this issue Jan 4, 2024
zepumph added a commit to phetsims/natural-selection that referenced this issue Jan 4, 2024
zepumph added a commit that referenced this issue Jan 4, 2024
zepumph added a commit to phetsims/number-line-distance that referenced this issue Jan 4, 2024
zepumph added a commit that referenced this issue Jan 4, 2024
zepumph added a commit to phetsims/number-line-integers that referenced this issue Jan 4, 2024
zepumph added a commit that referenced this issue Jan 4, 2024
zepumph added a commit to phetsims/number-line-operations that referenced this issue Jan 4, 2024
zepumph added a commit that referenced this issue Jan 4, 2024
zepumph added a commit to phetsims/sound-waves that referenced this issue Jan 4, 2024
@zepumph
Copy link
Member Author

zepumph commented Jan 4, 2024

Dependencies have been updated on branches. I'm doing local testing now to confirm this fixed things without causing regressions, then I'll proceed with deploying rcs (not for unpublished versions).

zepumph added a commit to phetsims/acid-base-solutions that referenced this issue Jan 4, 2024
zepumph added a commit to phetsims/center-and-variability that referenced this issue Jan 4, 2024
zepumph added a commit to phetsims/greenhouse-effect that referenced this issue Jan 4, 2024
zepumph added a commit to phetsims/keplers-laws that referenced this issue Jan 5, 2024
zepumph added a commit to phetsims/natural-selection that referenced this issue Jan 5, 2024
zepumph added a commit to phetsims/number-line-distance that referenced this issue Jan 5, 2024
zepumph added a commit to phetsims/number-line-integers that referenced this issue Jan 5, 2024
zepumph added a commit to phetsims/sound-waves that referenced this issue Jan 5, 2024
zepumph added a commit to phetsims/acid-base-solutions that referenced this issue Jan 5, 2024
zepumph added a commit to phetsims/center-and-variability that referenced this issue Jan 5, 2024
zepumph added a commit to phetsims/greenhouse-effect that referenced this issue Jan 5, 2024
zepumph added a commit to phetsims/keplers-laws that referenced this issue Jan 5, 2024
zepumph added a commit to phetsims/natural-selection that referenced this issue Jan 5, 2024
zepumph added a commit to phetsims/number-line-distance that referenced this issue Jan 5, 2024
zepumph added a commit to phetsims/number-line-integers that referenced this issue Jan 5, 2024
zepumph added a commit to phetsims/sound-waves that referenced this issue Jan 5, 2024
@zepumph
Copy link
Member Author

zepumph commented Jan 5, 2024

This was patched and deployed last night, I confirmed the lint error is fixed, and no other regressions were present.

Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant