-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on SHRED/Particle #63
Comments
The MR is worth it because this is likely the only lint error in all of our release branches, and so it is worth supporting lint for them generally. |
Ok, the fix has been applied to main. I have not started any patching of release branches, but will likely hit all release branches since 8/1. It will hit even unpublished sims. |
This is the list I found that needs the patch to lint on release branches:
That said, BAN isn't needed, since it has shred checked out, so I'll skip that one. |
Dependencies have been updated on branches. I'm doing local testing now to confirm this fixed things without causing regressions, then I'll proceed with deploying rcs (not for unpublished versions). |
This was patched and deployed last night, I confirmed the lint error is fixed, and no other regressions were present. Closing |
In phetsims/shred#38 I added this for type checking, but it should be more general than this, and it causes trouble if you lint phetcommon without shred checked out.
@jonathanolson and I spoke and we may want to MR all sims published with this since it was added in ce0920e. (8/1/23).
The text was updated successfully, but these errors were encountered: