Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design patterns discussion: mixins and traits #92

Closed
jessegreenberg opened this issue Feb 4, 2019 · 2 comments
Closed

Design patterns discussion: mixins and traits #92

jessegreenberg opened this issue Feb 4, 2019 · 2 comments

Comments

@jessegreenberg
Copy link
Contributor

As part of #88, this issue is to document discussion about PhET design patterns for mixins and traits.

Meeting discussion for this issue will likely occur on 2/4/19.
@jessegreenberg
Copy link
Contributor Author

Documentation is at https://github.com/phetsims/phet-info/blob/master/doc/phet-software-design-patterns.md#mixins--traits

samreid added a commit that referenced this issue Feb 4, 2019
@samreid
Rename "class" => "myClass" since "class" is a reserved keyword, see #92
27bb3fb
samreid added a commit that referenced this issue Feb 4, 2019
@samreid
Remove extraneous (), see #92
66fcb36
samreid added a commit that referenced this issue Feb 4, 2019
@samreid
Move mixInto call outside of class body, see #92
063715f
samreid added a commit that referenced this issue Feb 4, 2019
@samreid
Fix typo, see #92
9cf425a
samreid added a commit that referenced this issue Feb 4, 2019
@samreid
Add line breaks, see #92
b26174d
samreid added a commit that referenced this issue Feb 4, 2019
@samreid
Fix parameter type, see #92
9b01e4e
samreid added a commit that referenced this issue Feb 4, 2019
@samreid
Add docs, see #92
96cef72
samreid added a commit that referenced this issue Feb 4, 2019
@samreid
Fix typo, see #92
ca06f8a
jessegreenberg added a commit that referenced this issue Feb 4, 2019
@jessegreenberg
remove misleading information about mixin/trait vs inheritance, see #92
db68a8d
zepumph added a commit that referenced this issue Feb 6, 2019
@zepumph
updates to the dispose pattern, #92
7a16ed4
@jessegreenberg jessegreenberg mentioned this issue Feb 11, 2019
Closed
jessegreenberg added a commit that referenced this issue Feb 11, 2019
@jessegreenberg
Discussion topics for mixin/trait for next time, add 'Composition and…
f7394fa 
… Inheritance' section, see #92 and #88
jessegreenberg added a commit to phetsims/phet-core that referenced this issue Feb 11, 2019
@jessegreenberg
trait -> mixin in documentation after discussion in phetsims/phet-inf…
d2cd9a6 
…o#92
jessegreenberg added a commit that referenced this issue Feb 18, 2019
@jessegreenberg
add item to mixin/trait agenda, see #92
4b4b86c
jessegreenberg added a commit that referenced this issue Feb 25, 2019
@jessegreenberg
exemplify disposal of mixin/trait, see #92
53e2cee
jessegreenberg added a commit that referenced this issue Feb 25, 2019
@jessegreenberg
remove remaining topic, see #92
13474a4
jessegreenberg added a commit that referenced this issue Feb 25, 2019
@jessegreenberg
finalize notes on mixin/trait, see #92
54833a9
@jessegreenberg
Copy link
Contributor Author

2/25/19 we had our final discussion about mixin and trait. I updated the documentation in https://github.com/phetsims/phet-info/blob/master/doc/phet-software-design-patterns.md to reflect discussion.

phetsims/phet-core#54 is still open to investigate how to guard against shadowing when using mixin/trait, and when decisions are made there we can update the design patterns document. A not about this was made in the design patterns md file.

I think this can be closed, and we will continue with #93 next time.

samreid added a commit that referenced this issue Apr 23, 2022
@samreid
Rename "class" => "myClass" since "class" is a reserved keyword, see #92
16623bc
samreid added a commit that referenced this issue Apr 23, 2022
@samreid
Remove extraneous (), see #92
22dfe41
samreid added a commit that referenced this issue Apr 23, 2022
@samreid
Move mixInto call outside of class body, see #92
8ff891b
samreid added a commit that referenced this issue Apr 23, 2022
@samreid
Fix typo, see #92
54e8ce9
samreid added a commit that referenced this issue Apr 23, 2022
@samreid
Add line breaks, see #92
c16b1f4
samreid added a commit that referenced this issue Apr 23, 2022
@samreid
Fix parameter type, see #92
6107ece
samreid added a commit that referenced this issue Apr 23, 2022
@samreid
Add docs, see #92
59fccd1
samreid added a commit that referenced this issue Apr 23, 2022
@samreid
Fix typo, see #92
f254f51
samreid pushed a commit that referenced this issue Apr 23, 2022
@jessegreenberg
remove misleading information about mixin/trait vs inheritance, see #92
e0e9021
samreid pushed a commit that referenced this issue Apr 23, 2022
@zepumph
updates to the dispose pattern, #92
2c0b3c1
samreid pushed a commit that referenced this issue Apr 23, 2022
@jessegreenberg
Discussion topics for mixin/trait for next time, add 'Composition and…
b50d298 
… Inheritance' section, see #92 and #88
samreid pushed a commit that referenced this issue Apr 23, 2022
@jessegreenberg
add item to mixin/trait agenda, see #92
5b08e5f
samreid pushed a commit that referenced this issue Apr 23, 2022
@jessegreenberg
exemplify disposal of mixin/trait, see #92
81e7600
samreid pushed a commit that referenced this issue Apr 23, 2022
@jessegreenberg
remove remaining topic, see #92
c057002
samreid pushed a commit that referenced this issue Apr 23, 2022
@jessegreenberg
finalize notes on mixin/trait, see #92
4426865
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jessegreenberg