Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reopenIssuesFromTODOs no longer works #362

Closed
samreid opened this issue Sep 23, 2024 · 4 comments
Closed

reopenIssuesFromTODOs no longer works #362

samreid opened this issue Sep 23, 2024 · 4 comments
Assignees
@zepumph
Labels
priority:2-high

Comments

@samreid
Copy link
Member

samreid commented Sep 23, 2024

This is because saveTODOIssues environment variable no longer propagates now that grunt tasks are in separate processes.
@samreid samreid self-assigned this Sep 23, 2024
@zepumph zepumph self-assigned this Sep 23, 2024
@samreid
Copy link
Member Author

samreid commented Sep 23, 2024

Maybe we just need to make sure the env propagates through.

zepumph added a commit to phetsims/chipper that referenced this issue Sep 24, 2024
@zepumph
provide env through to grunt tasks, phetsims/perennial#362
bdb4ed9 
Signed-off-by: Michael Kauzmann <michael.kauzmann@colorado.edu>
@zepumph
Copy link
Member

zepumph commented Sep 24, 2024

I'll check back in tomorrow to see if this worked.

@zepumph
Copy link
Member

zepumph commented Sep 26, 2024

I see that the script is now writing the TODO issues to chipper/dist nightly. The next issue is that bayes is still running node v16.

@zepumph zepumph mentioned this issue Nov 4, 2024
Closed
zepumph added a commit that referenced this issue Nov 5, 2024
@zepumph
bug fix when moving chipper/eslint to perennial/js/eslint/, #362
10a88ef
zepumph added a commit that referenced this issue Nov 5, 2024
@zepumph
rename to ts, #362
7ee10cd
zepumph added a commit that referenced this issue Nov 5, 2024
@zepumph
convert to ts, #362
a6faef5
zepumph added a commit that referenced this issue Nov 5, 2024
@zepumph
use lint module instead of sub process, #362
c51cf89
zepumph added a commit that referenced this issue Nov 5, 2024
@zepumph
nested inside eslint/, #362
8ef6ac1
zepumph added a commit to phetsims/aqua that referenced this issue Nov 5, 2024
@zepumph
remove TODO test, phetsims/perennial#362
80a5ee8
zepumph added a commit to phetsims/chipper that referenced this issue Nov 5, 2024
@zepumph
ignore json files, phetsims/perennial#362
4220f3c
@zepumph
Copy link
Member

zepumph commented Nov 5, 2024

I believe this is fixed now! running on bayes worked to reopen phetsims/aqua#219.

@zepumph zepumph closed this as completed Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zepumph zepumph

Labels
priority:2-high
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samreid @zepumph