Skip to content

Commit

Permalink
buildtools/tsconfig is better as a single reference to chipper/tsconf…
Browse files Browse the repository at this point in the history
…ig-node.json phetsims/chipper#1463
  • Loading branch information
zepumph authored and samreid committed Oct 21, 2024
1 parent d3949f5 commit c2c390e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 19 deletions.
1 change: 0 additions & 1 deletion tsconfig/buildjson/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
"../../../joist/images/**/*",
"../../../joist/js/**/*",
"../../../joist/sounds/**/*",
// TODO: kite/js/grunt/ is node code. Oh boy, let's talk about this https://github.com/phetsims/chipper/issues/1469
"../../../kite/js/**/*",
"../../../phet-core/js/**/*",
// It's OK to list private repo phet-io files here, even though open source clients cannot check them out.
Expand Down
20 changes: 2 additions & 18 deletions tsconfig/buildtools/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,24 +1,8 @@

// TODO: Ideally, the contents here would be an extends, but typescript really doesn't want me to do that. https://github.com/phetsims/chipper/issues/1463
//{
// // Chipper and its node dependencies is what we call "buildtools"
// "extends": "../../../chipper/tsconfig-node.json"
//}
{
"extends": "../../tsconfig/shared/tsconfig-node.json",
"include": [
"../../js/common/**/*",
"../../js/grunt/**/*",
"../../js/phet-io/**/*",
"../../js/scripts/**/*",
"../../test/**/*",
"../../eslint/**/*",
// Gruntfile and eslint.config.mjs
"../../*"
],
// Chipper and its node dependencies is what we call "buildtools"
"references": [
{
"path": "../../../perennial-alias/tsconfig-chipper.json"
"path": "../../tsconfig-node.json"
}
]
}

0 comments on commit c2c390e

Please sign in to comment.