Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model.md #7

Closed
pixelzoom opened this issue Feb 8, 2020 · 7 comments
Closed

model.md #7

pixelzoom opened this issue Feb 8, 2020 · 7 comments
Assignees

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Feb 8, 2020

Related to #2 (code review). model.md needs to be written.

  • Does model.md adequately describe the model, in terms appropriate for teachers?
@pixelzoom
Copy link
Contributor Author

pixelzoom commented Feb 11, 2020

@ariel-phet asked me to label this one high priority.

PhET currently doesn't have a standard for what's in the model.md file, and it varies dramatically from sim to sim. The audience for model.md is non-programmers, typically teachers who want to know (at a high level) how the sim's model works.

A good recent example is https://github.com/phetsims/vector-addition/blob/master/doc/model.md

After model.md is written, it should be reviewed by the sim's lead designer (not a programmer).

Hyodar added a commit that referenced this issue Mar 4, 2020
@Hyodar Hyodar self-assigned this Mar 4, 2020
@Hyodar
Copy link
Contributor

Hyodar commented Mar 4, 2020

The latest commit has the first version of the model description. It took a while because I rewrote some parts a couple of times, but I think it's at least acceptable now.

@Hyodar
Copy link
Contributor

Hyodar commented Mar 4, 2020

@pixelzoom , could you give us some feedback about it before the review? We would really appreciate it.

@Hyodar
Copy link
Contributor

Hyodar commented Mar 4, 2020

Also, I have to take a trip for a few days starting tomorrow, so I'll assign @tmildemberger here to make changes if necessary.

@pixelzoom
Copy link
Contributor Author

This looks great. I made one change in the above commit -- "Options" means something to PhET. Some sims have an Options choice under the PhET menu, where you can open an Options dialog and set global options. So I changed "Options" to "Additional Controls".

@tmildemberger If you have additional changes that you'd like reviewed, feel free to assign back to me. If not, feel free to close this issue. Thanks!

@pixelzoom
Copy link
Contributor Author

I noticed in #8 (implementation-notes.md) that there is actually an OptionsPanel. So I took the liberty of renaming it to NormalModesControlPanel.js in the above commit. I'll also update in implementation-notes.md.

@Hyodar
Copy link
Contributor

Hyodar commented Jul 10, 2020

Yes, that sounds nice. Thanks for reviewing!

I'll go ahead and close the issue, then.

@Hyodar Hyodar closed this as completed Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants