Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review for color-blindness accessibility #39

Closed
pixelzoom opened this issue Feb 10, 2020 · 4 comments
Closed

review for color-blindness accessibility #39

pixelzoom opened this issue Feb 10, 2020 · 4 comments

Comments

@pixelzoom
Copy link
Contributor

Related to #2 (code review):

-[ ] Is PhetColorScheme used where appropriate? Verify that the sim is not inventing/creating its own colors for things that have been standardized in PhetColorScheme. Identify any colors that might be worth adding to PhetColorScheme.

SpringNodes.js and NormalModesIconFactory.js currently use stroke: 'red'. Should they be using PhetColorScheme.RED_COLORBLIND?

@Hyodar
Copy link
Contributor

Hyodar commented Feb 17, 2020

Replaced both of them to RED_COLORBLIND. Closing the issue, if necessary reopen it.

@Hyodar Hyodar closed this as completed Feb 17, 2020
@Hyodar Hyodar self-assigned this Feb 17, 2020
@pixelzoom
Copy link
Contributor Author

Reopening. Sorry that I wasn't clear on this one. Colors are typically reviewed by a sim designer, to check for color-blindness accessibility. And the possible use of PhetColorScheme.RED_COLORBLIND was just one example. So before you do anything else, a sim designer will review and (possibly) request color changes.

@pixelzoom pixelzoom reopened this Feb 17, 2020
@pixelzoom pixelzoom assigned arouinfar and unassigned Hyodar Feb 17, 2020
@Hyodar
Copy link
Contributor

Hyodar commented Feb 17, 2020

No problem! We'll be waiting for your review.

@DianaTavares
Copy link

We have an updated version of the mockup for this simulation. I test for colorblind and looks like to colors we are using are appropriate. All the components in the sim can be recognized well.

image
image
image

Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants