-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
review for color-blindness accessibility #39
Comments
Replaced both of them to |
Reopening. Sorry that I wasn't clear on this one. Colors are typically reviewed by a sim designer, to check for color-blindness accessibility. And the possible use of PhetColorScheme.RED_COLORBLIND was just one example. So before you do anything else, a sim designer will review and (possibly) request color changes. |
No problem! We'll be waiting for your review. |
We have an updated version of the mockup for this simulation. I test for colorblind and looks like to colors we are using are appropriate. All the components in the sim can be recognized well. Closing this issue. |
Related to #2 (code review):
SpringNodes.js and NormalModesIconFactory.js currently use
stroke: 'red'
. Should they be usingPhetColorScheme.RED_COLORBLIND
?The text was updated successfully, but these errors were encountered: