misuses of options pattern

[pixelzoom]

There is a definite misunderstanding about how to use options, which is one of PhET's fundamental design patterns.

Some examples:

  class OptionsPanel extends Panel {

    /**
     * @param {Object} [panelOptions]
     * @param {Model} model
     * @param {bool} doShowPhases
     */
    constructor( panelOptions, model, doShowPhases = false ) {

  class AmpPhaseAccordionBox extends AccordionBox {
    // TODO - comment code

    /**
     * @param {Object} [options]
     * @param {Model} model
     */
    constructor( options, model ) {

  class AmpSelectorRectNode extends Rectangle {

    /**
     * @param {Object} [options]
     * @param {Model} model
     */
    constructor( options, model, row, col, ampAxisProperty, maxAmpProperty, gridSizeProperty ) {

A description of PHET's "Options and Config" pattern can be found in PhET Software Design Patterns. Because it is optional, options should always be the last parameter.

[Hyodar]

Made some changes to the usage of options, though I think some of those classes could still use some cleaning up beyond just changing options to be the last constructor parameter.
I'll take a closer look tomorrow and then close the issue if everything is fine.

[Hyodar]

Closing. If necessary, it can be opened again.