Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assertion failures: strings with trailing spaces #13

Closed
pixelzoom opened this issue Feb 8, 2020 · 2 comments
Closed

assertion failures: strings with trailing spaces #13

pixelzoom opened this issue Feb 8, 2020 · 2 comments
Labels
dev:code-review status:ready-for-review type:bug Something isn't working

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Feb 8, 2020 •
edited
Loading

Related to #2 (code review). When running with ?ea, the sim experiences multiple assertion failures related to translated string values that have trailing spaces. E.g.:

Assertion failed: String should not have trailing or leading whitespace, key: numberOfMasses, value: "Number of Masses: "
pixelzoom added a commit that referenced this issue Feb 8, 2020
@pixelzoom
remove trailing space in string values, #13
d5ba9d1
@pixelzoom pixelzoom changed the title assertion failures assertion failures: strings with trailing spaces Feb 8, 2020
@pixelzoom pixelzoom added dev:code-review type:bug Something isn't working labels Feb 8, 2020
@pixelzoom
Copy link
Contributor Author

Multiple string values were fixed in the above commit.

This was referenced Feb 8, 2020
Closed
Closed
@Hyodar
Copy link
Contributor

Hyodar commented Jul 6, 2020

Understood!
Since it's already fixed and ready for review, I'll just close the issue.

@Hyodar Hyodar closed this as completed Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev:code-review status:ready-for-review type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pixelzoom @Hyodar