Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keyboard number input should auto work when mouse opens KeypadDialog #106

Closed
zepumph opened this issue Mar 13, 2023 · 3 comments
Closed

keyboard number input should auto work when mouse opens KeypadDialog #106

zepumph opened this issue Mar 13, 2023 · 3 comments
Assignees
@zepumph
Labels
status:ready-for-review

Comments

@zepumph
Copy link
Member

zepumph commented Mar 13, 2023

From #86 and @samreid and @zepumph's thoughts. Let's have this behavior work like so:

  1. Click the number display with a mouse which opens a dialog
  2. Pressing numbers on the keyboard will then input into the keypad.
@zepumph zepumph self-assigned this Mar 13, 2023
zepumph added a commit to phetsims/scenery-phet that referenced this issue Mar 13, 2023
@zepumph
KeypadDialog focuses Keypad on show, phetsims/my-solar-system#106
648dcec
@zepumph
Copy link
Member Author

zepumph commented Mar 13, 2023 •
edited
Loading

@jessegreenberg, this was really quite straight forward, but would you quickly spot check me to see if you have any improvements?

@zepumph zepumph assigned jessegreenberg and unassigned zepumph Mar 13, 2023
@AgustinVallejo
Copy link
Contributor

Looking really good on our side!!

@jessegreenberg
Copy link
Contributor

Code change looks good!

@zepumph zepumph closed this as completed Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zepumph zepumph

Labels
status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jessegreenberg @zepumph @AgustinVallejo