Skip to content

Commit

Permalink
TODO #953
Browse files Browse the repository at this point in the history
  • Loading branch information
pixelzoom committed Mar 12, 2024
1 parent 7ab9eea commit 4596a79
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions js/preferences/RegionAndCulturePortrayal.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
// Copyright 2022-2024, University of Colorado Boulder

//TODO Delete this class after we have removed portrayals from sims, see https://github.com/phetsims/joist/issues/953
/**
* A base class for the portrayal of people, places, or objects in the sim. Region and culture is a preference supported
* by PreferencesModel and query parameters. The supported region and culture instances for a sim are defined by the
Expand Down Expand Up @@ -111,10 +112,8 @@ export default class RegionAndCulturePortrayal extends PhetioObject {
validValues: validValues
} );

// TODO: This is a temporary solution to keep the two Properties in sync until we have finish porting
// the regionAndCulturePortrayalProperty usages to the regionAndCultureProperty. These links can be removed
// once the post is complete. https://github.com/phetsims/joist/issues/953
// NOTE: In the future, this (risky) bidirectional
//TODO https://github.com/phetsims/joist/issues/953 This is a temporary solution to keep the two Properties in
// sync until we have finish porting regionAndCulturePortrayalProperty usages to regionAndCultureProperty.
regionAndCulturePortrayalProperty.link( regionAndCulturePortrayal => {
regionAndCultureProperty.value = regionAndCulturePortrayal.regionAndCulture;
} );
Expand Down

0 comments on commit 4596a79

Please sign in to comment.