Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrument the play area panels #55

Closed
samreid opened this issue Jun 8, 2018 · 3 comments
Closed

Instrument the play area panels #55

samreid opened this issue Jun 8, 2018 · 3 comments

Comments

@samreid
Copy link
Member

samreid commented Jun 8, 2018

For #38, we would like to be able to hide the entire slider control Panel, not just the contents of the panel, and we would like the content tandem to be nested in the panel tandem. I'll demonstrate one way to accomplish this for the Energy screen.

@samreid samreid self-assigned this Jun 8, 2018
samreid added a commit that referenced this issue Jun 8, 2018
@samreid
Copy link
Member Author

samreid commented Jun 8, 2018

Please see the hookes-law commit for how this was accomplished. @pixelzoom can you please review and, if it seems good, apply the same strategy to the other screens?

@samreid samreid assigned pixelzoom and unassigned samreid Jun 8, 2018
pixelzoom added a commit that referenced this issue Jun 8, 2018
Signed-off-by: Chris Malley <cmalley@pixelzoom.com>
@pixelzoom
Copy link
Contributor

Looks good. I applied the same pattern to the other panels. I shortened tandem name (e.g.) "springConstantControlPanel" to "springConstantPanel" throughout. @samreid Take a peek, close if this looks OK.

@pixelzoom pixelzoom assigned samreid and unassigned pixelzoom Jun 8, 2018
@samreid
Copy link
Member Author

samreid commented Jun 8, 2018

The change sets look great, closing.

@samreid samreid closed this as completed Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants