Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

duplicate code in *ViewProperties #50

Closed
pixelzoom opened this issue Jun 6, 2018 · 1 comment
Closed

duplicate code in *ViewProperties #50

pixelzoom opened this issue Jun 6, 2018 · 1 comment
Assignees
@pixelzoom
Labels
design:phet-io dev:code-review

Comments

@pixelzoom
Copy link
Contributor

Each screen has its own type that contains view-specific Properties. They are IntroViewProperties, SystemsViewProperties and EnergyViewProperties. These screen have 4 Properties in common, and they are currently duplicated in the each of these types. These common Properties should be factored out prior to PhET-iO instrumentation, so that we're not instrumenting the same 4 Properties three times.
@pixelzoom pixelzoom self-assigned this Jun 6, 2018
pixelzoom added a commit that referenced this issue Jun 6, 2018
@pixelzoom
factor out duplicate view-specific Properties, #50
17f1a85 
Signed-off-by: Chris Malley <cmalley@pixelzoom.com>
pixelzoom added a commit that referenced this issue Jun 6, 2018
@pixelzoom
@OverRide annotation for reset, #50
0e8808a 
Signed-off-by: Chris Malley <cmalley@pixelzoom.com>
pixelzoom added a commit that referenced this issue Jun 6, 2018
@pixelzoom
call super constructor first #50
f48a62f 
Signed-off-by: Chris Malley <cmalley@pixelzoom.com>
@pixelzoom
Copy link
Contributor Author

Done, fuzz tested, closing.

@pixelzoom pixelzoom mentioned this issue Jun 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pixelzoom pixelzoom

Labels
design:phet-io dev:code-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pixelzoom