add missing tandems #38

Signed-off-by: Chris Malley <cmalley@pixelzoom.com>
phetsims · Jun 7, 2018 · 33cb5f6 · 33cb5f6
1 parent 18b640c
commit 33cb5f6
Show file tree

Hide file tree

Showing 6 changed files with 18 additions and 10 deletions.
diff --git a/js/common/view/EquilibriumPositionNode.js b/js/common/view/EquilibriumPositionNode.js
@@ -26,7 +26,7 @@ define( function( require ) {
       stroke: HookesLawColors.EQUILIBRIUM_POSITION,
       lineWidth: 2,
       lineDash: [ 3, 3 ],
-      tandem: Tandem.required
+      tandem: Tandem.optional // because this node is used to create icons
     }, options );
 
     Line.call( this, 0, 0, 0, length, options );

diff --git a/js/common/view/RoboticArmNode.js b/js/common/view/RoboticArmNode.js
@@ -150,7 +150,10 @@ define( function( require ) {
 
       end: function( event ) {
         numberOfInteractionsInProgressProperty.set( numberOfInteractionsInProgressProperty.get() - 1 );
-      }
+      },
+
+      // phet-io
+      tandem: options.tandem.createTandem( 'dragHandler' )
     } );
     draggableNode.addInputListener( dragHandler );
 

diff --git a/js/intro/view/IntroSceneControl.js b/js/intro/view/IntroSceneControl.js
@@ -36,8 +36,8 @@ define( function( require ) {
     }, options );
 
     RadioButtonGroup.call( this, numberOfSystemsProperty, [
-      { value: 1, node: HookesLawIconFactory.createSingleSpringIcon() },
-      { value: 2, node: HookesLawIconFactory.createTwoSpringsIcon() }
+      { value: 1, node: HookesLawIconFactory.createSingleSpringIcon(), tandemName: 'oneSystemRadioButton' },
+      { value: 2, node: HookesLawIconFactory.createTwoSpringsIcon(), tandemName: 'twoSystemsRadioButton' }
     ], options );
   }
 

diff --git a/js/intro/view/IntroVisibilityControls.js b/js/intro/view/IntroVisibilityControls.js
@@ -84,12 +84,15 @@ define( function( require ) {
     var equilibriumPositionCheckbox = new Checkbox(
       HookesLawIconFactory.createEquilibriumPositionCheckboxContent(),
       properties.equilibriumPositionVisibleProperty,
-      HookesLawConstants.CHECK_BOX_OPTIONS );
+      _.extend( {
+        tandem: options.tandem.createTandem( 'equilibriumPositionCheckbox' )
+      }, HookesLawConstants.CHECK_BOX_OPTIONS ) );
+
     var valuesCheckbox = new Checkbox(
       new Text( valuesString, HookesLawConstants.CONTROL_TEXT_OPTIONS ),
       properties.valuesVisibleProperty,
       _.extend( {
-        tandem: options.tandem.createTandem( 'equilibriumPositionCheckbox' )
+        tandem: options.tandem.createTandem( 'valuesCheckbox' )
       }, HookesLawConstants.CHECK_BOX_OPTIONS ) );
 
     // 'Values' checkbox pertains to vectors, so enable that checkbox only if one or more of the vectors is selected.

diff --git a/js/systems/view/SystemsSceneControl.js b/js/systems/view/SystemsSceneControl.js
@@ -36,8 +36,8 @@ define( function( require ) {
     }, options );
 
     RadioButtonGroup.call( this, seriesParallelProperty, [
-      { value: 'parallel', node: HookesLawIconFactory.createParallelSystemIcon() },
-      { value: 'series', node: HookesLawIconFactory.createSeriesSystemIcon() }
+      { value: 'parallel', node: HookesLawIconFactory.createParallelSystemIcon(), tandemName: 'parallelRadioButton' },
+      { value: 'series', node: HookesLawIconFactory.createSeriesSystemIcon(), tandemName: 'seriesRadioButton' }
     ], options );
   }
 

diff --git a/js/systems/view/SystemsScreenView.js b/js/systems/view/SystemsScreenView.js
@@ -62,7 +62,8 @@ define( function( require ) {
       unitDisplacementLength: unitDisplacementLength,
       left: this.layoutBounds.left + 15, //careful! position this so that max applied force vector doesn't go offscreen or overlap control panel
       centerY: this.layoutBounds.centerY,
-      visible: viewProperties.seriesParallelProperty.get() === 'series'
+      visible: viewProperties.seriesParallelProperty.get() === 'series',
+      tandem: tandem.createTandem( 'seriesSystemNode' )
     } );
     this.addChild( seriesSystemNode );
 
@@ -71,7 +72,8 @@ define( function( require ) {
       unitDisplacementLength: unitDisplacementLength,
       left: seriesSystemNode.left,
       centerY: this.layoutBounds.centerY,
-      visible: viewProperties.seriesParallelProperty.get() === 'parallel'
+      visible: viewProperties.seriesParallelProperty.get() === 'parallel',
+      tandem: tandem.createTandem( 'parallelSystemNode' )
     } );
     assert && assert( parallelSystemNode.height < this.layoutBounds.height, 'parallel system is too tall' );
     this.addChild( parallelSystemNode );