Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation changes after https://github.com/phetsims/scenery/issues/1403 #322

Closed
jessegreenberg opened this issue Apr 14, 2022 · 1 comment
Closed

Implementation changes after https://github.com/phetsims/scenery/issues/1403 #322

jessegreenberg opened this issue Apr 14, 2022 · 1 comment
Assignees
@jessegreenberg

Comments

@jessegreenberg
Copy link
Contributor

jessegreenberg commented Apr 14, 2022 •
edited
Loading

After phetsims/scenery#1403 changes are coming to Alerter.ts and Voicing.ts which may require implementation changes in the sim. This issue is to track and review.
@jessegreenberg jessegreenberg self-assigned this Apr 14, 2022
jessegreenberg added a commit to phetsims/gravity-force-lab that referenced this issue Apr 14, 2022
@jessegreenberg
reusable public Utterance for a context response when constant size c…
1cb8a62 
…heckbox changes, see phetsims/gravity-force-lab-basics#322
@jessegreenberg jessegreenberg mentioned this issue Apr 14, 2022
Closed
jessegreenberg added a commit that referenced this issue Apr 14, 2022
@jessegreenberg
reusable public Utterance for a context response when constant size c…
4eb32fb 
…heckbox changes, see #322
@jessegreenberg
Copy link
Contributor Author

OK, I think thats it for this issue, most other voicing responses are made with voicingSpeak* functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jessegreenberg jessegreenberg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jessegreenberg