Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No cursor change on hover #157

Closed
zepumph opened this issue Aug 4, 2021 · 3 comments
Closed

No cursor change on hover #157

zepumph opened this issue Aug 4, 2021 · 3 comments

Comments

@zepumph
Copy link
Member

zepumph commented Aug 4, 2021

I noticed for for #154, during my first time using this sim, that it seems a bit strange to me that the "pointer" cursor only appears once you begin dragging the elements in the sim. I would have expected a cursor change on hover to help cue what is draggable. For example, it wasn't immediately clear to me that only the left pencil was draggable, and not the right one (the refracted image).

@kathy-phet
Copy link

Fix this for prototype, if easy.

@pixelzoom
Copy link
Contributor

pixelzoom commented Sep 14, 2021

I was asked to evaluate this issue for https://github.com/phetsims/geometric-optics/milestone/1. Fixed in the above commit.

@arouinfar please review in master. All draggable objects now have cursor: 'pointer' (the hand) when you hover over them. The exceptions are the lens and mirror. Since they can only be moved up/down, they have cursor: 'ns-resize' (up/down arrows).

@pixelzoom pixelzoom assigned arouinfar and unassigned veillette Sep 14, 2021
@pixelzoom pixelzoom added status:ready-for-review type:bug Something isn't working labels Sep 14, 2021
@pixelzoom
Copy link
Contributor

9/23/21 design meeting: Looks good, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants