-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implementation-notes.md #135
Comments
I added to the implementation node before the code review although there is surely more confusing aspect of the similation that could be fleshed out. |
Note some formatting done in 276d32b |
Honestly. I thought that was a very intelligently written implementation notes markdown. It helped get me up to speed quite well on the physics and code structure. Up to you how much more you would like to flesh out. |
I make another pass through this later, to note any changes that I make. |
implementation-notes.md
adequately describe the implementation, with an overview that will be useful to future maintainers?
See #196 (comment) for terminology used in the code. This should be used to revise implementation-notes.md. |
implementation-notes.md is ready for review by whoever does the sim code review. |
@jonathanolson Please review as part of code review #402. |
Implementation and model notes are excellent! Thank you. |
From the CRC:
See https://github.com/phetsims/geometric-optics/blob/master/doc/implementation-notes.md
The text was updated successfully, but these errors were encountered: