manually dispose KeyboardHelpSectionRows, phetsims/scenery-phet#769

phetsims · Apr 4, 2023 · f8a264d · f8a264d
1 parent 4352cb8
commit f8a264d
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/js/common/view/GOKeyboardHelpContent.ts b/js/common/view/GOKeyboardHelpContent.ts
@@ -101,8 +101,7 @@ class MoveDraggableItemsSection extends KeyboardHelpSection {
 
     this.disposeMoveDraggableItemsSection = () => {
       icons.forEach( icon => icon.dispose() );
-      //TODO https://github.com/phetsims/scenery-phet/issues/769 uncomment when KeyboardHelpSection no longer disposes of content
-      //rows.forEach( row => row.dispose() );
+      rows.forEach( row => row.dispose() );
     };
   }
 
@@ -148,8 +147,7 @@ class RulerAndMarkerControlsSection extends KeyboardHelpSection {
 
     this.disposeRulerAndMarkerControlsSection = () => {
       keyNodes.forEach( keyNode => keyNode.dispose() );
-      //TODO https://github.com/phetsims/scenery-phet/issues/769 uncomment when KeyboardHelpSection no longer disposes of content
-      //rows.forEach( row => row.dispose() );
+      rows.forEach( row => row.dispose() );
     };
   }