Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create pressureAtmospheresProperty #256

Closed
arouinfar opened this issue Jun 5, 2024 · 2 comments
Closed

Create pressureAtmospheresProperty #256

arouinfar opened this issue Jun 5, 2024 · 2 comments
Assignees
@arouinfar
Labels
dev:phet-io status:ready-for-review

Comments

@arouinfar
Copy link
Contributor

For #30

Under pressureModel, we provide the pressure value with and without noise in kPa, but only provide the noisy version for atm.
image

@pixelzoom can we create pressureAtmospheresProperty so clients can access the pressure in atm without noise?
@arouinfar arouinfar changed the title Create pressureAtmosphereProperty Create pressureAtmospheresProperty Jun 5, 2024
pixelzoom added a commit that referenced this issue Jun 10, 2024
@pixelzoom
add pressureAtmospheresProperty, #256
73078ae
@pixelzoom
Copy link
Contributor

@arouinfar please review, close if OK.

@pixelzoom pixelzoom assigned arouinfar and unassigned pixelzoom Jun 10, 2024
@arouinfar
Copy link
Contributor Author

Looks good, closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arouinfar arouinfar

Labels
dev:phet-io status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pixelzoom @arouinfar