Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "Cumulative" from heavySpeedCumulativeBinCountsProperty #251

Closed
arouinfar opened this issue Jun 5, 2024 · 2 comments
Closed

Remove "Cumulative" from heavySpeedCumulativeBinCountsProperty #251

arouinfar opened this issue Jun 5, 2024 · 2 comments
Assignees
@arouinfar
Labels
dev:phet-io status:ready-for-review type:bug

Comments

@arouinfar
Copy link
Contributor

For #30

For the most part, the tandems for histogram bin counts follow the same pattern of {{speciesHistogramType}}BinCountsProperty:
image

heavySpeedCumulativeBinCountsProperty is an outlier. For consistency, let's remove "Cumulative".
pixelzoom added a commit that referenced this issue Jun 10, 2024
@pixelzoom
fix tandem name, #251
e3649e3
@pixelzoom
Copy link
Contributor

This was a buggy tandem name, fixed in the above commits. @arouinfar please review, close if OK.

@pixelzoom pixelzoom assigned arouinfar and unassigned pixelzoom Jun 10, 2024
@arouinfar
Copy link
Contributor Author

Looks good on main, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arouinfar arouinfar

Labels
dev:phet-io status:ready-for-review type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pixelzoom @arouinfar