-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keyboard help for alt input. #215
Comments
In 1ea5644, I added stubs for the keyboard help in each screen. @arouinfar let's figure out what we want for each screen. |
…ic MoveHandlesKeyboardHelpSection, #215
…ic MoveHandlesKeyboardHelpSection, phetsims/gas-properties#215
Some additional work that needs to be done:
|
@arouinfar FYI I added a placeholder for 'Spinner Controls' in the Gas Properties keyboard help, so that we can get a feel for space/layout/etc. until phetsims/scenery-phet#847 is completed. I'm not suggesting that this should inform the final design - we just needed something to fill the approximate amount of space. In the first 3 screens, it looks like this, because the FineCoarseSpinners are horizontal and support 'Shift': In the Diffusion screen, it looks like this, because the NumberSpinners are vertical and do not support 'Shift': |
What about using language like "bursts" and "singles" or is that idea sim-specific? |
Also, are the size of the small steps (singles) and large steps (bursts) always fixed or can they be random bursts? |
Maybe the bike pump is the randomizer, and the FineCoarseSpinner gives more precision? |
@terracoda I don't know what you're referring to here. Can you please clarify, and maybe note what previous comment(s) in this issue your question is directed towards? |
I was referring to the language for the big and small steps of the fine coarse spinner - pressing the arrow key is like a burst and pressing the shift + arrow is like a single. Apologies if this is wrong issue in which to comment. |
More detail is over in phetsims/scenery-phet#847 (comment) |
Discussed with @arouinfar. We'll need keyboard help for HeaterCoolerNode, so we'll keep "Slider Controls" help as a placeholder until phetsims/scenery-phet#853 is wrapped up. On hold until then... |
The last remaining task for this issue is to integrate help for HeaterCoolerNode when it's available. See phetsims/scenery-phet#853, assigned to @arouinfar for review. On hold until then ... |
In #213 (comment), @Nancy-Salpepi said:
Added in 8628472. |
We'd like to get this sim into dev testing by Friday 6/21, so removing the hold. @jessegreenberg Is it possible to complete phetsims/scenery-phet#853 before Friday? Do you need any additional input or assistance from the GP team? @arouinfar The keyboard help dialogs are large, with lots of redundancy. I'm not quite sure where we're going to squeeze in the help for HeaterCoolerNode. Thoughts on what we need to do to have this ready for dev testing? |
Discussed with @arouinfar. TODO:
|
Over to @arouinfar for a (final?) review. Anything else to change? If not, feel free to close. |
Looks good on main, thanks @pixelzoom. Closing. |
Related to #213 ...
We'll need to add keyboard help for alt input. There are many questions here.
The text was updated successfully, but these errors were encountered: