Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard help for alt input. #215

Closed
pixelzoom opened this issue Mar 18, 2024 · 19 comments
Closed

Keyboard help for alt input. #215

pixelzoom opened this issue Mar 18, 2024 · 19 comments

Comments

@pixelzoom
Copy link
Contributor

Related to #213 ...

We'll need to add keyboard help for alt input. There are many questions here.

@pixelzoom
Copy link
Contributor Author

In 1ea5644, I added stubs for the keyboard help in each screen. @arouinfar let's figure out what we want for each screen.

pixelzoom added a commit that referenced this issue Apr 4, 2024
pixelzoom added a commit that referenced this issue Apr 4, 2024
pixelzoom added a commit to phetsims/babel that referenced this issue Apr 4, 2024
@pixelzoom pixelzoom changed the title Add keyboard help for alt input. Keyboard help for alt input. Apr 11, 2024
@pixelzoom
Copy link
Contributor Author

pixelzoom commented Apr 17, 2024

Some additional work that needs to be done:

screenshot_3226

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Apr 17, 2024

@arouinfar FYI I added a placeholder for 'Spinner Controls' in the Gas Properties keyboard help, so that we can get a feel for space/layout/etc. until phetsims/scenery-phet#847 is completed. I'm not suggesting that this should inform the final design - we just needed something to fill the approximate amount of space.

In the first 3 screens, it looks like this, because the FineCoarseSpinners are horizontal and support 'Shift':
screenshot_3231

In the Diffusion screen, it looks like this, because the NumberSpinners are vertical and do not support 'Shift':
screenshot_3229

@terracoda
Copy link

What about using language like "bursts" and "singles" or is that idea sim-specific?

@terracoda
Copy link

Also, are the size of the small steps (singles) and large steps (bursts) always fixed or can they be random bursts?

@terracoda
Copy link

Maybe the bike pump is the randomizer, and the FineCoarseSpinner gives more precision?

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Apr 19, 2024

What about using language like "bursts" and "singles" or is that idea sim-specific?

@terracoda I don't know what you're referring to here. Can you please clarify, and maybe note what previous comment(s) in this issue your question is directed towards?

@terracoda
Copy link

I was referring to the language for the big and small steps of the fine coarse spinner - pressing the arrow key is like a burst and pressing the shift + arrow is like a single.

Apologies if this is wrong issue in which to comment.

@terracoda
Copy link

More detail is over in phetsims/scenery-phet#847 (comment)

pixelzoom added a commit to phetsims/faradays-electromagnetic-lab that referenced this issue Apr 22, 2024
@pixelzoom
Copy link
Contributor Author

pixelzoom commented Apr 30, 2024

... Do you want me to remove "Slider Controls" in the meantime?

Discussed with @arouinfar. We'll need keyboard help for HeaterCoolerNode, so we'll keep "Slider Controls" help as a placeholder until phetsims/scenery-phet#853 is wrapped up. On hold until then...

@pixelzoom
Copy link
Contributor Author

pixelzoom commented May 13, 2024

The last remaining task for this issue is to integrate help for HeaterCoolerNode when it's available. See phetsims/scenery-phet#853, assigned to @arouinfar for review. On hold until then ...

@pixelzoom pixelzoom removed their assignment May 20, 2024
@pixelzoom
Copy link
Contributor Author

pixelzoom commented Jun 17, 2024

In #213 (comment), @Nancy-Salpepi said:

The hotkey for Play/Pause is going to be really useful when setting up experiments. It should be added to the Keyboard Shortcuts Dialog to remind users of it.

Added in 8628472.

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Jun 17, 2024

We'd like to get this sim into dev testing by Friday 6/21, so removing the hold.

@jessegreenberg Is it possible to complete phetsims/scenery-phet#853 before Friday? Do you need any additional input or assistance from the GP team?

@arouinfar The keyboard help dialogs are large, with lots of redundancy. I'm not quite sure where we're going to squeeze in the help for HeaterCoolerNode. Thoughts on what we need to do to have this ready for dev testing?

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Jun 17, 2024

Discussed with @arouinfar. TODO:

  • Replace SliderControlsKeyboardHelpSection with HeatCoolControlsKeyboardHelpSection
  • "Change Choice" => "Change Units"

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Jun 18, 2024

Over to @arouinfar for a (final?) review. Anything else to change? If not, feel free to close.

@arouinfar
Copy link
Contributor

Looks good on main, thanks @pixelzoom. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants