We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discovered in phetsims/axon#441 ...
Relevant code and fix in IdealGasLawContainer:
- this.isOpenProperty = new DerivedProperty( [ this.lidIsOnProperty, this.lidWidthProperty ], + this.isOpenProperty = new DerivedProperty( [ this.lidIsOnProperty, this.lidWidthProperty, this.boundsProperty ], - ( lidIsOn, lidWidth ) => { + ( lidIsOn, lidWidth, bounds ) => { return !lidIsOn || this.getOpeningWidth() !== 0; } );
this.getOpeningWidth calls this.getOpeningLeft, which calls this.left, which is a getter that uses this.boundsProperty.
this.getOpeningWidth
this.getOpeningLeft
this.left
this.boundsProperty
This needs to be tested before pushing.
The text was updated successfully, but these errors were encountered:
In 699b3b8, @samreid added accessNonDependencies: true to temporarily silence this problem.
accessNonDependencies: true
Sorry, something went wrong.
TODOs for hhttps://github.com//issues/211, phetsims/axon#441
a3238e7
add missing dependency, #211
7ee5c39
Fixed in the above commit. Closing.
pixelzoom
No branches or pull requests
Discovered in phetsims/axon#441 ...
Relevant code and fix in IdealGasLawContainer:
this.getOpeningWidth
callsthis.getOpeningLeft
, which callsthis.left
, which is a getter that usesthis.boundsProperty
.This needs to be tested before pushing.
The text was updated successfully, but these errors were encountered: