simplify derivation of isOpenProperty, #212

phetsims · Dec 15, 2023 · 1902bbb · 1902bbb
1 parent c8de0ea
commit 1902bbb
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/js/common/model/IdealGasLawContainer.ts b/js/common/model/IdealGasLawContainer.ts
@@ -108,8 +108,8 @@ export default class IdealGasLawContainer extends BaseContainer {
     this.previousLeft = this.left;
 
     this.isOpenProperty = new DerivedProperty(
-      [ this.lidIsOnProperty, this.lidWidthProperty, this.boundsProperty ],
-      ( lidIsOn, lidWidth, bounds ) => !lidIsOn || this.getOpeningWidth() !== 0
+      [ this.lidIsOnProperty, this.lidWidthProperty ],
+      ( lidIsOn, lidWidth ) => !lidIsOn || ( lidWidth < this.getMaxLidWidth() )
     );
   }