Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes required after the addition of canAnnounceProperties #298

Closed
jessegreenberg opened this issue Apr 14, 2022 · 2 comments
Closed

Changes required after the addition of canAnnounceProperties #298

jessegreenberg opened this issue Apr 14, 2022 · 2 comments
Assignees
@zepumph
Labels
status:ready-for-review

Comments

@jessegreenberg
Copy link
Contributor

After phetsims/scenery#1403 changes are coming to Alerter.ts and Voicing.ts which may require implementation changes in the sim. This issue is to track and review.
@jessegreenberg jessegreenberg self-assigned this Apr 14, 2022
jessegreenberg added a commit that referenced this issue Apr 14, 2022
@jessegreenberg
Do not use voicingUtteranceQueue.addToBack and register Utterances to…
379e614 
… a VoicingNode, see #298
@jessegreenberg jessegreenberg mentioned this issue Apr 14, 2022
Closed
jessegreenberg added a commit that referenced this issue Apr 16, 2022
@jessegreenberg
register Alerter Utterances to the ScreenView, see #298
2adba8f
@jessegreenberg
Copy link
Contributor Author

OK, this transition is done. In 379e614 the Alerter Utterances were registered to the chemistryBookNode because it was required to register them to a VoicingNode with a voicingCanSpeakProperty.

Later in phetsims/scenery#1403 I added a registerUtteranceToNode which can link to a voicingVisibleProperty so that we can register Utterances to the ScreenView which is something we thought was beneficial in phetsims/scenery#1403 (comment).

The Utterances are coming through as I would expect with the "Sim Voicing" toggle in the toolbar. @zepumph this is ready for you to verify.

@zepumph
Copy link
Member

zepumph commented May 25, 2022

Awesome, thanks!

@zepumph zepumph closed this as completed May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zepumph zepumph

Labels
status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jessegreenberg @zepumph