-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Voicing with Safari reads period as "dot" in licensing section of PhET-iO About Dialog #282
Comments
I'll look at what the voicing string looks like and see if it is weird. |
I can't seem to load the sim on my iPad right now, but my best guess here is that it has to do with when we use |
I just tried this on iPad os 15.6 and couldn't reproduce. @Nancy-Salpepi do you mind double checking on your end? Feel free to close. |
@zepumph I can still reproduce this on my MacBook Air (macOS 12.5.1 + Safari 15.6.1) and on my desktop (macOS 10.15.7 + Safari 15.6.1). |
We found that our voicing code was incorrectly replacing a I also wanted to note that we were able to reproduce the bug with the "Alex" voice on safari, but not with "Samantha". Given this, in the future, it may be helpful for QA to provide the voice that a bug occurred with when a bug is related to voicing. |
Looks good in master. @zepumph I will add a line in the QA book about noting the voice used when making issues and will mention at QA meeting tomorrow. |
Test device
MacBook Air (m1 chip)
Operating System
12.3
Browser
Safari
Problem description
For phetsims/qa#791, in the PhET-iO sim, Voicing reads the period as "dot" in the licensing section of the About dialog. It does this for the first 2 sentences, but not for the last sentence in that section.
Steps to reproduce
Visuals
dotSafari.mov
The text was updated successfully, but these errors were encountered: