Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voicing with Safari reads period as "dot" in licensing section of PhET-iO About Dialog #282

Closed
Nancy-Salpepi opened this issue Mar 31, 2022 · 6 comments

Comments

@Nancy-Salpepi
Copy link

Test device
MacBook Air (m1 chip)

Operating System
12.3

Browser
Safari

Problem description
For phetsims/qa#791, in the PhET-iO sim, Voicing reads the period as "dot" in the licensing section of the About dialog. It does this for the first 2 sentences, but not for the last sentence in that section.

  • This does not occur anywhere else in the sim where there is a period (preferences dialog, 'Thanks' section of the About dialog)
  • This does not occur with Mac + Chrome
  • This does not occur anywhere in the PhET brand sim

Steps to reproduce

  1. Using Safari, Turn on Voicing in the PhET-iO brand sim.
  2. Read through the About dialog in the PhET menu.

Visuals

dotSafari.mov
Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: ‪Friction‬ URL: https://phet-dev.colorado.edu/html/friction/1.6.0-dev.24/phet/friction_all_phet.html Version: 1.6.0-dev.24 2022-03-30 15:06:07 UTC Features missing: applicationcache, applicationcache, touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/99.0.4844.84 Safari/537.36 Language: en-US Window: 1431x690 Pixel Ratio: 2/1 WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium) GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 31 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {}
@zepumph
Copy link
Member

zepumph commented Jun 24, 2022

I'll look at what the voicing string looks like and see if it is weird.

@zepumph
Copy link
Member

zepumph commented Jul 15, 2022

I can't seem to load the sim on my iPad right now, but my best guess here is that it has to do with when we use
tags in RichText.

@zepumph
Copy link
Member

zepumph commented Aug 26, 2022

I just tried this on iPad os 15.6 and couldn't reproduce. @Nancy-Salpepi do you mind double checking on your end? Feel free to close.

@Nancy-Salpepi
Copy link
Author

@zepumph I can still reproduce this on my MacBook Air (macOS 12.5.1 + Safari 15.6.1) and on my desktop (macOS 10.15.7 + Safari 15.6.1).
I was not able to reproduce this issue on the iPad either.

@zepumph
Copy link
Member

zepumph commented Aug 29, 2022

We found that our voicing code was incorrectly replacing a <br> tag with nothing, where instead it should have been adding a space to things. Solved above in phetsims/utterance-queue@2c543b0. @Nancy-Salpepi can you please confirm things are fixed and feel free to close.

I also wanted to note that we were able to reproduce the bug with the "Alex" voice on safari, but not with "Samantha". Given this, in the future, it may be helpful for QA to provide the voice that a bug occurred with when a bug is related to voicing.

@Nancy-Salpepi
Copy link
Author

Looks good in master. @zepumph I will add a line in the QA book about noting the voice used when making issues and will mention at QA meeting tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants