UI sounds were enabled unintentionally.

[pixelzoom]

For phetsims/qa#735.

While testing this sim for the 1.1 release, I suddenly realized that UI sounds have been enabled. We didn't do this intentionally, and this sim has never had a sound design, or even a discussion about sound.

@jbphet enabled all UI sounds when he switched to tambo-based for GameAudioPlayer, common code (in vegas) which plays sounds related to the game. For Equality Explorer, this was first done in the main.js (22f9aad), then moved to package.json (8bf530b). And according to phetsims/vegas#77 and phetsims/chipper#806, this was done for ALL sims that use GameAudioPlayer.

@amanda-phet @kathy-phet

• Did we really want to enable all UI sounds for this sim, before having the opportnity to discuss or (possibly) add UI sounds to fill in the gaps? It doesn't feel like a very good "sound experience" to me.
• Is this a problem for all sims that have a Game? I've asked this more generally in Rewrite GameAudioPlayer to use tambo vegas#77 (comment).

[pixelzoom]

My recommendation for addressing this in Equality Explorer 1.1 is described in phetsims/vegas#77 (comment).

[pixelzoom]

11/18/21 design meeting:

The workaround in phetsims/vegas#77 (comment) was approved. I'll need to:

• turn off 'ui-sounds' category
• cherry-picking fixes from Sounds were not added to category 'ui-sounds'. vegas#98

[pixelzoom]

Fixes for phetsims/vegas#98 were cherry-picked in phetsims/vegas@e2629f8 and phetsims/scenery-phet@8a4f7f6.

[pixelzoom]

Work is done in master and 1.1 branches.

@KatieWoe would you please assign someone from QA to test this?

If this looks OK, change the label to "fixed-awaiting-deploy".

To test:

1. Run the sim from master with ?showAnswers&reward=2
2. Verify that there is no sound for the UI controls. (You don't need to test every one of them, just a random sample.)
3. In the Game screen, verify that there is no sound for the level-selection buttons, and the back button on the scoreboard.
4. Go to any one of the levels in the Game. (Testing one level is fine, no need to test them all.)
5. Press the red "show answer" button. You should hear the "ding" sound when the smiley face becomes visible.
6. Press the red "show answer" button again. You should hear the "cheering" sound when the reward becomes visible.
7. Turn off sound in the navigation bar.
8. Repeat steps 4,5,6 for a different level. You should hear no sound after pushing the "show answer" button.

[KatieWoe]

Looks good on master

[pixelzoom]

To verify in 1.1.0-rc.2, follow the steps in #177 (comment).

[KatieWoe]

Looks good in RC.2