Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use scenery-phet.SkyNode #405

Closed
Tracked by #408
pixelzoom opened this issue Feb 23, 2021 · 1 comment
Closed
Tracked by #408

Use scenery-phet.SkyNode #405

pixelzoom opened this issue Feb 23, 2021 · 1 comment
Assignees
@chrisklus

Comments

@pixelzoom
Copy link
Contributor

While working on https://github.com/phetsims/scenery-phet/issues/79 and related to phetsims/balancing-act#128... I noticed that EFAC does not use scenery-phet/SkyNode, and has its own implementation of SkyNode. Should it be using scenery-phet/SkyNode?
@chrisklus chrisklus mentioned this issue Apr 28, 2021
Open
6 tasks
@chrisklus
Copy link
Contributor

Thanks @pixelzoom. EFAC has it's own implementation with a couple different gradients and a solid area to handle the disappearance of energy chunks after they rise up for a while. I think this is good to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisklus chrisklus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pixelzoom @chrisklus