You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[balancing-act] currently has its own implementation, OutsideBackgroundNode.
OutsideBackgroundNode is, I believe, a common code node in scenery-phet that uses the aforementioned scenery-phet.SkyNode in conjunction with a scenery-phet.GroundNode to create a background with both ground and sky. So, I'm thinking the implementation in balancing-act is fine as is. My guess is that @pixelzoom didn't realize that OutsideBackgroundNode was a scenery-phet thing.
Yeah, that must've been it. Sorry for not digging deeper. For context, my quick review was for an ancient scenery-phet issue that I finally transferred to phetsims/fluid-pressure-and-flow#335 (comment).
From https://github.com/phetsims/scenery-phet/issues/79#issue-44468162:
While working on correcting this problem, I noticed that balancing-act is not using SkyNode. Should it be?
It currently has its own implementation, OutsideBackgroundNode.
The text was updated successfully, but these errors were encountered: