Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use scenery-phet.SkyNode #128

Closed
pixelzoom opened this issue Feb 23, 2021 · 2 comments
Closed

Use scenery-phet.SkyNode #128

pixelzoom opened this issue Feb 23, 2021 · 2 comments
Assignees

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Feb 23, 2021

From https://github.com/phetsims/scenery-phet/issues/79#issue-44468162:

Currently, many sims with sky node exhibit the same bug as phetsims/fluid-pressure-and-flow#87 including BalancingAct.

While working on correcting this problem, I noticed that balancing-act is not using SkyNode. Should it be?

It currently has its own implementation, OutsideBackgroundNode.

@pixelzoom pixelzoom changed the title Use SkyNode Use scenery-phet.SkyNode Feb 23, 2021
@jbphet
Copy link
Contributor

jbphet commented Mar 12, 2021

@pixelzoom said:

[balancing-act] currently has its own implementation, OutsideBackgroundNode.

OutsideBackgroundNode is, I believe, a common code node in scenery-phet that uses the aforementioned scenery-phet.SkyNode in conjunction with a scenery-phet.GroundNode to create a background with both ground and sky. So, I'm thinking the implementation in balancing-act is fine as is. My guess is that @pixelzoom didn't realize that OutsideBackgroundNode was a scenery-phet thing.

Right?

@jbphet jbphet assigned pixelzoom and unassigned jbphet Mar 12, 2021
@pixelzoom
Copy link
Contributor Author

pixelzoom commented Mar 12, 2021

Yeah, that must've been it. Sorry for not digging deeper. For context, my quick review was for an ancient scenery-phet issue that I finally transferred to phetsims/fluid-pressure-and-flow#335 (comment).

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants