Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

old releases re-create chipper/eslint/cache/ #1508

Closed
zepumph opened this issue Oct 25, 2024 · 3 comments
Closed

old releases re-create chipper/eslint/cache/ #1508

zepumph opened this issue Oct 25, 2024 · 3 comments
Assignees
@zepumph
Labels
status:ready-for-review

Comments

@zepumph
Copy link
Member

zepumph commented Oct 25, 2024

Lint on release branches (like with grunt rc), and then when you checkout main again, you still have a chipper/eslint/cache/ directory. Let's fix this.
@zepumph
Copy link
Member Author

zepumph commented Oct 28, 2024

Current fix just deletes the chipper/eslint/ dir when running lint. This seems acceptable to me only because I also added back in chipper/eslint/ to the gitignore on main.

zepumph added a commit to phetsims/perennial that referenced this issue Oct 28, 2024
@zepumph
better support for old cache location from linting on release branches,
7c067aa 
phetsims/chipper#1508
zepumph added a commit that referenced this issue Oct 28, 2024
@zepumph
better support for old cache location from linting on release branches,
8b5ecc3 
#1508
@zepumph
Copy link
Member Author

zepumph commented Oct 28, 2024

@samreid, any thoughts from here? Feel free to close.

@samreid
Copy link
Member

samreid commented Oct 28, 2024 •
edited
Loading

Looks good to me, thanks. Does it need to be cherry-picked into recent RC branches? Feel free to close if not.

@samreid samreid assigned zepumph and unassigned samreid Oct 28, 2024
@zepumph zepumph closed this as completed Oct 28, 2024
@zepumph zepumph mentioned this issue Oct 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zepumph zepumph

Labels
status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samreid @zepumph