Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert node to sage/tsx in bash scripts that have the word "node" in them (we can ignore yotta) #1506

Open
samreid opened this issue Oct 23, 2024 · 2 comments
Assignees

Comments

@samreid
Copy link
Member

samreid commented Oct 23, 2024

From #1481. Convert node to sage/tsx in bash scripts that have the word "node" in them (we can ignore yotta)

Start with daily-grunt-work.sh as a warm-up.

@zepumph zepumph self-assigned this Nov 4, 2024
zepumph added a commit to phetsims/perennial that referenced this issue Nov 4, 2024
@zepumph
Copy link
Member

zepumph commented Nov 4, 2024

sage run doesn't currently support node options, for example it errors on this patch:

Subject: [PATCH] Just pull all always, https://github.com/phetsims/phettest/issues/14
---
Index: bin/main-pull-status.sh
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/bin/main-pull-status.sh b/bin/main-pull-status.sh
--- a/bin/main-pull-status.sh	(revision 4892575778ce7afc8bbaf6058f5b37662767b398)
+++ b/bin/main-pull-status.sh	(date 1730762253961)
@@ -9,4 +9,4 @@
 #====================================================================================================
 
 cd perennial
-node --no-warnings js/scripts/main-pull-status.js
+./bin/sage run --no-warnings js/scripts/main-pull-status.js

@zepumph zepumph removed their assignment Nov 4, 2024
zepumph added a commit to phetsims/perennial that referenced this issue Nov 5, 2024
@zepumph zepumph self-assigned this Nov 5, 2024
@zepumph
Copy link
Member

zepumph commented Nov 6, 2024

I'd like to touch base with @jonathanolson about the yotta half of these. Some of them look to use perennial dependencies, but I want to ask how he'd like the entry points to behave. I invited him to our standup this morning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants