Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prune Grunt tasks #1461

Open
samreid opened this issue Sep 13, 2024 · 1 comment
Open

Prune Grunt tasks #1461

samreid opened this issue Sep 13, 2024 · 1 comment

Comments

@samreid
Copy link
Member

samreid commented Sep 13, 2024

Discovered in #1459, there are many tasks in chipper's Gruntfile.js or perennial's Gruntfile.js that:

  • appear unused
  • are unrelated to the other grunt responsibilities

@zepumph and I recommend reviewing each grunt task to see if it can be deleted or moved to a separately executable script. Things that should remain are: simulation lifecycle events like grunt --brands=phet grunt dev grunt rc grunt lint and their dependencies. And for tasks that must remain stable, well-supported, and backward-compatible for maintenance tasks.

This work will help us modularize & limit our usage of grunt, which we would like to "abandon" #1436

It will also free us up to use other runtimes (such as deno or tsx) or TypeScript as desired.

I will tag suspicious grunt tasks, then bring to Monday's developer meeting. I will make annotations in perennial/main and chipper's typescript_chipper_1459_b branch. (and they can (mostly?) be seen below)

@zepumph
Copy link
Member

zepumph commented Oct 10, 2024

Much of this issue should probably wait until we finish discussing phetsims/perennial#370.

zepumph added a commit to phetsims/perennial that referenced this issue Oct 10, 2024
zepumph added a commit to phetsims/perennial that referenced this issue Oct 10, 2024
samreid pushed a commit to phetsims/perennial that referenced this issue Oct 11, 2024
samreid pushed a commit to phetsims/perennial that referenced this issue Oct 11, 2024
samreid added a commit to phetsims/phet-core that referenced this issue Oct 14, 2024
samreid added a commit to phetsims/wave-interference that referenced this issue Oct 14, 2024
samreid added a commit to phetsims/phet-lib that referenced this issue Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants