Skip to content

Commit

Permalink
always build the allHTML, #1454
Browse files Browse the repository at this point in the history
Signed-off-by: Michael Kauzmann <michael.kauzmann@colorado.edu>
  • Loading branch information
zepumph committed Aug 22, 2024
1 parent bc68674 commit 379a0b2
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
3 changes: 1 addition & 2 deletions js/grunt/Gruntfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,6 @@ Runnable build options:
--report-media - Will iterate over all of the license.json files and reports any media files, set to false to opt out.
--brands={{BRANDS} - Can be * (build all supported brands), or a comma-separated list of brand names. Will fall back to using
build-local.json's brands (or adapted-from-phet if that does not exist)
--allHTML - If provided, will include the _all.html file (if it would not otherwise be built, e.g. phet brand)
--XHTML - Includes an xhtml/ directory in the build output that contains a runnable XHTML form of the sim (with
a separated-out JS file).
--locales={{LOCALES}} - Can be * (build all available locales, "en" and everything in babel), or a comma-separated list of locales
Expand Down Expand Up @@ -270,7 +269,7 @@ Minify-specific options:
grunt.log.writeln( `Building runnable repository (${repo}, brands: ${brands.join( ', ' )})` );

// Other options
const allHTML = !!grunt.option( 'allHTML' );
const allHTML = true; // Always build this artifact
const encodeStringMap = grunt.option( 'encodeStringMap' ) !== false;
const compressScripts = !!grunt.option( 'compressScripts' );
const profileFileSize = !!grunt.option( 'profileFileSize' );
Expand Down
2 changes: 1 addition & 1 deletion js/grunt/profileFileSize.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
*
* To profile a sim, go to the sim directory and run:
*
* grunt --allHTML --locales=* --brands=phet --profileFileSize
* grunt --locales=* --brands=phet --profileFileSize
* grunt profile-file-size
*
* @author Jonathan Olson <jonathan.olson@colorado.edu>
Expand Down
2 changes: 1 addition & 1 deletion test/chainsBuildTest.js
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ qunit.test( 'Build (no args)', async assert => {

qunit.test( 'Build (with added HTMLs)', async assert => {
assert.timeout( 120000 );
await execute( gruntCommand, [ '--brands=phet,phet-io', '--allHTML', '--debugHTML' ], { cwd: '../chains' } );
await execute( gruntCommand, [ '--brands=phet,phet-io', '--debugHTML' ], { cwd: '../chains' } );
assertChainsExistence( assert, 'phet', { allHTML: true, debugHTML: true } );
assertChainsExistence( assert, 'phet-io', { allHTML: true, debugHTML: true } );
} );
Expand Down

0 comments on commit 379a0b2

Please sign in to comment.