Skip to content

Commit

Permalink
better TODO issue, #1415
Browse files Browse the repository at this point in the history
Signed-off-by: Michael Kauzmann <michael.kauzmann@colorado.edu>
  • Loading branch information
zepumph committed Mar 21, 2024
1 parent 31298c5 commit 1791f8f
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions js/grunt/lint.js
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ const lint = async ( originalRepos, options ) => {

const inProgressErrorLogging = repos.length > 1;

// TODO: always use MAX_THREADS and calculate batch size to be optimal, https://github.com/phetsims/chipper/issues/1356
// TODO: always use MAX_THREADS and calculate batch size to be optimal, https://github.com/phetsims/chipper/issues/1415
const MAX_THREADS = 4; // Max number of concurrent workers
const MAX_BATCH_SIZE = 60; // Number of repos processed by each worker (could be less if total is not divisible)
const allResults = [];
Expand Down Expand Up @@ -264,7 +264,6 @@ const lint = async ( originalRepos, options ) => {
lint.chipperAPIVersion = 'promisesPerRepo1';

// only used by the lintWorker.js, please don't use this.
// TODO: Is there a better way to expose this? https://github.com/phetsims/chipper/issues/1415
lint.lintReposFromWorker = lintReposFromWorker;

module.exports = lint;

0 comments on commit 1791f8f

Please sign in to comment.