Skip to content

Commit

Permalink
{Repo}Images.ts should begin with uppercase, entries in file should h…
Browse files Browse the repository at this point in the history
…ave ImageProperty suffix, phetsims/joist#953
  • Loading branch information
pixelzoom committed Mar 5, 2024
1 parent dd6a53e commit 14bb553
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions js/grunt/modulify.js
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ const createImageModule = async ( repo, supportedRegionsAndCultures ) => {
const spec = grunt.file.readJSON( `../${repo}/${repo}-images.json` );
const namespace = _.camelCase( repo );
const imageModuleName = `${pascalCase( repo )}Images`;
const relativeImageModuleFile = `js/${namespace}Images.ts`;
const relativeImageModuleFile = `js/${imageModuleName}.ts`;

const providedRegionsAndCultures = Object.keys( spec );

Expand Down Expand Up @@ -416,7 +416,7 @@ ${imageFiles.map( imageFile => `import ${getImportName( imageFile )} from '../${
const ${imageModuleName} = {
${imageNames.map( imageName =>
`${imageName}: new LocalizedImageProperty( '${imageName}', {
`${imageName}ImageProperty: new LocalizedImageProperty( '${imageName}', {
${supportedRegionsAndCultures.map( regionAndCulture => `${regionAndCulture}: ${getImportName( spec[ regionAndCulture ][ imageName ] )}` ).join( ',\n ' )}
} )` ).join( ',\n ' )}
};
Expand Down

0 comments on commit 14bb553

Please sign in to comment.