Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preliminary testing before dev test #518

Closed
samreid opened this issue Aug 28, 2023 · 8 comments
Closed

Preliminary testing before dev test #518

samreid opened this issue Aug 28, 2023 · 8 comments

Comments

@samreid
Copy link
Member

samreid commented Aug 28, 2023

Today @matthew-blackman asked if @catherinecarter could take a look through the sim before we begin dev testing, to see if there are problems that need to be addressed before testing. He indicated this would be good to check particularly regarding the focus highlights, keyboard/mouse cues, etc and all those new features. But I would recommend even broader testing--please open new issues for any problems you see.

@catherinecarter
Copy link
Contributor

catherinecarter commented Aug 29, 2023

A screenshot of a new perspective. After reset-all, my tab was in the nav bar so I shift-tabbed so I could kick more. When shift-tabbing, the soccer ball play area is tabbed to first, and this is what I saw (so no balls had been kicked):

Image

Next, I kicked 5 and pressed tab once:

Image

Kicked 5 more (maxKicks=10), and prior to tabbing, saw this:
Image

after tabbing, saw this:
Image

@catherinecarter
Copy link
Contributor

It looks like the drag indicator, as well as the alt-input focus, is currently being placed on the rightmost ball rather than the last kicked ball. Is this the case? If so, we'll want the drag indicator (and the focus) to be on the last ball kicked.

In the case when the last ball kicked lands in the stack of the median, rather than have the logic go to the 2nd-last ball kicked, maybe move it one stack right or left of the Median stack?

@samreid
Copy link
Member Author

samreid commented Aug 29, 2023

Good catch @catherinecarter, likely broken because phetsims/soccer-common@9487bb0 has a different sort order, thanks!

@samreid
Copy link
Member Author

samreid commented Aug 30, 2023

Some other errors reported in #516 (comment) which may have been addressed:

image

image

@catherinecarter
Copy link
Contributor

I'm not sure how much work has been done one the alt-input drag indicator/focus rectangle match-up, but I'm seeing some strange behavior when tabbing prior to exhausting maxKicks (as of 8/30 in the am). Here you can see the number of kicks is 10 in the first shot, and then maxed at 15 in the second.

Image

Image

@samreid
Copy link
Member Author

samreid commented Aug 30, 2023

Thanks, I was able to reproduce the problem--the issue was that if a soccer ball gets focus, we want to show the indicators there. I'll push a proposed commit for testing.

@samreid
Copy link
Member Author

samreid commented Aug 30, 2023

@catherinecarter can you help test after that change?

@samreid samreid changed the title Precursor design testing before dev test Preliminary testing before dev test Aug 31, 2023
@marlitas
Copy link
Contributor

marlitas commented Sep 6, 2023

The work in this issue now seems to be overlapping with #521. Closing this issue.

@marlitas marlitas closed this as completed Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants