-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preliminary testing before dev test #518
Comments
It looks like the drag indicator, as well as the alt-input focus, is currently being placed on the rightmost ball rather than the last kicked ball. Is this the case? If so, we'll want the drag indicator (and the focus) to be on the last ball kicked. In the case when the last ball kicked lands in the stack of the median, rather than have the logic go to the 2nd-last ball kicked, maybe move it one stack right or left of the Median stack? |
Good catch @catherinecarter, likely broken because phetsims/soccer-common@9487bb0 has a different sort order, thanks! |
Some other errors reported in #516 (comment) which may have been addressed: |
I'm not sure how much work has been done one the alt-input drag indicator/focus rectangle match-up, but I'm seeing some strange behavior when tabbing prior to exhausting maxKicks (as of 8/30 in the am). Here you can see the number of kicks is 10 in the first shot, and then maxed at 15 in the second. |
Thanks, I was able to reproduce the problem--the issue was that if a soccer ball gets focus, we want to show the indicators there. I'll push a proposed commit for testing. |
@catherinecarter can you help test after that change? |
The work in this issue now seems to be overlapping with #521. Closing this issue. |
Today @matthew-blackman asked if @catherinecarter could take a look through the sim before we begin dev testing, to see if there are problems that need to be addressed before testing. He indicated this would be good to check particularly regarding the focus highlights, keyboard/mouse cues, etc and all those new features. But I would recommend even broader testing--please open new issues for any problems you see.
The text was updated successfully, but these errors were encountered: