Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If you click in the splash screen, a sound plays on startup #261

Closed
samreid opened this issue Jun 14, 2023 · 5 comments
Closed

If you click in the splash screen, a sound plays on startup #261

samreid opened this issue Jun 14, 2023 · 5 comments
Assignees
Labels
dev:help-wanted Extra attention is needed dev:sound

Comments

@samreid
Copy link
Member

samreid commented Jun 14, 2023

If you click in the splash screen, a sound plays on startup. Discovered in #252

@samreid samreid self-assigned this Jun 14, 2023
@samreid
Copy link
Member Author

samreid commented Jun 19, 2023

I ran 12 tests to check this, and I heard a half cut-off card whoosh sound once. Very difficult to reproduce the problem. @marlitas or @matthew-blackman does this occur more frequently on your platforms?

@samreid samreid assigned marlitas and matthew-blackman and unassigned samreid Jun 19, 2023
@marlitas
Copy link
Contributor

@samreid I tried this about 10 times and didn't hear anything... This might be a "Let's see if it crops up in QA" bug... if it's that rare might not be worth investigation.

@marlitas marlitas removed their assignment Jun 20, 2023
@matthew-blackman
Copy link
Contributor

I think I can reproduce this pretty regularly, but only when dev tools are not open in Chrome. Super weird. Is it the faint "thud" sound that sometimes plays when clicking on the loading screen with the PhET logo?

Did some logging on startup and found that the following are logged on launch, but there are no changes to the logs when the errant sound is produced.

NumberTone.ts:139 medianSoundClip.play()
CardNode.ts:173 randomSound.play() - logged 15 times
CardNode.ts:173 randomSound.play() - logged 15 times
NumberTone.ts:139 medianSoundClip.play()
NumberTone.ts:139 medianSoundClip.play()

Could this be something happening as sounds are being loaded/buffered?

@matthew-blackman matthew-blackman added the dev:help-wanted Extra attention is needed label Jun 21, 2023
@samreid
Copy link
Member Author

samreid commented Jun 21, 2023

Thanks, with the chrome dev tools closed, I was able to hear a sound in 2/6 tries. It sounds like the card sound to me.

@samreid samreid self-assigned this Jun 21, 2023
samreid added a commit that referenced this issue Jun 21, 2023
@samreid
Copy link
Member Author

samreid commented Jun 21, 2023

@matthew-blackman and I tracked down the sounds with SoundClip.play debugger, and found that several sounds were triggered during construction. We changed the links to lazyLink, and it seemed to work well. We will open a tambo issue to discuss with @jbphet whether tambo should gracefully ignore sounds before the sim starts, or throw an assertion. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev:help-wanted Extra attention is needed dev:sound
Projects
None yet
Development

No branches or pull requests

3 participants