Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prisms get away from the mouse #372

Open
samreid opened this issue Apr 6, 2017 · 8 comments
Open

Prisms get away from the mouse #372

samreid opened this issue Apr 6, 2017 · 8 comments

Comments

@samreid
Copy link
Member

samreid commented Apr 6, 2017

Noted in master: go to 2nd screen, drag a prism from the toolbox. Depending on your screen size, the prism will go faster than the mouse.

@samreid
Copy link
Member Author

samreid commented Jun 21, 2017

Still happening to this day.

@samreid
Copy link
Member Author

samreid commented May 25, 2018

Observed again today. This would block republication.

@KatieWoe
Copy link
Contributor

KatieWoe commented Jan 9, 2019

Found again today while testing phetsims/qa#226. Assuming it is unrelated due to the age of the issue.

@pixelzoom
Copy link
Contributor

Sounds like an incorrect coordinate transform in a drag handler, maybe confusion between globalToParentPosition and globalToLocalPosition (or something like that...)

@KatieWoe
Copy link
Contributor

KatieWoe commented Mar 2, 2020

Found again during ES6 Testing

@samreid
Copy link
Member Author

samreid commented Jun 11, 2020

Unassigning until I return to bending light.

@samreid samreid removed their assignment Jun 11, 2020
@samreid samreid self-assigned this Jan 30, 2021
@samreid samreid added this to the PhET-iO Instrumentation milestone Jan 30, 2021
@samreid
Copy link
Member Author

samreid commented Jan 31, 2021

I tested master in a wide variety of screen sizes, and tried dragging prisms from the toolbox and in the play area. Nothing got away from the mouse. I'm not sure how this was corrected, but I don't see obvious commits in bending-light that would explain it. Closing... (for now?)

@samreid samreid closed this as completed Jan 31, 2021
@samreid
Copy link
Member Author

samreid commented Jul 3, 2021

Reopening based on the 3 TODOs marking this issue in the code, they seem like they need attention.

@samreid samreid reopened this Jul 3, 2021
@samreid samreid removed their assignment Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants