Skip to content

Commit

Permalink
TypeScript conversion for Panel, ComboBox (and assorted types), see p…
Browse files Browse the repository at this point in the history
  • Loading branch information
jonathanolson committed Mar 5, 2022
1 parent a03c9b2 commit a5cbff2
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions js/common/view/MediumControlPanel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import { Node } from '../../../../scenery/js/imports.js';
import { Rectangle } from '../../../../scenery/js/imports.js';
import { Text } from '../../../../scenery/js/imports.js';
import ArrowButton from '../../../../sun/js/buttons/ArrowButton.js';
import ComboBox from '../../../../sun/js/ComboBox.js';
import ComboBox, { ComboBoxListPosition } from '../../../../sun/js/ComboBox.js';
import ComboBoxItem from '../../../../sun/js/ComboBoxItem.js';
import HSlider from '../../../../sun/js/HSlider.js';
import Panel from '../../../../sun/js/Panel.js';
Expand All @@ -46,7 +46,7 @@ const PLUS_MINUS_SPACING = 4;
const INSET = 10;

type MediumControlPanelOptions = {
comboBoxListPosition?: number,
comboBoxListPosition?: ComboBoxListPosition,
yMargin?: number,
lineWidth?: number
};
Expand Down Expand Up @@ -164,7 +164,8 @@ class MediumControlPanel extends Node {
listPosition: options.comboBoxListPosition,
xMargin: 7,
yMargin: 4,
arrowHeight: 6,
// TODO: arrowHeight doesn't exist in ComboBox, should we add that feature?
// arrowHeight: 6,
cornerRadius: 3
} );

Expand Down

0 comments on commit a5cbff2

Please sign in to comment.