Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Africa, Africa Modest, Asia, Latin America, and Oceania character sets #8

Closed
Luisav1 opened this issue Nov 20, 2023 · 6 comments
Closed

Add Africa, Africa Modest, Asia, Latin America, and Oceania character sets #8

Luisav1 opened this issue Nov 20, 2023 · 6 comments
Assignees
@amanda-phet
Labels
status:ready-for-review

Comments

@Luisav1
Copy link
Contributor

Luisav1 commented Nov 20, 2023

First need to add a preference model and then we'll add the classes and structure for the character sets.
@Luisav1 Luisav1 self-assigned this Nov 20, 2023
@amanda-phet amanda-phet changed the title Add Africa, Africa Modest, Asia, and Latin America character sets Add Africa, Africa Modest, Asia, Latin America, and Oceania character sets Nov 21, 2023
Luisav1 added a commit that referenced this issue Nov 22, 2023
@Luisav1
Add preferences model and structure for character sets. See #8 and ph…
d4d2db3 
…etsims/area-model-algebra#7.
Luisav1 added a commit to phetsims/area-model-algebra that referenced this issue Nov 22, 2023
@Luisav1
Add preferences model and structure for character sets. See phetsims/…
7ee0eee 
…area-model-multiplication#8 and #7.
Luisav1 added a commit to phetsims/area-model-common that referenced this issue Nov 22, 2023
@Luisav1
Add preferences model and structure for character sets. See phetsims/…
efeb8f9 
…area-model-multiplication#8 and phetsims/area-model-algebra#7.
Luisav1 added a commit to phetsims/babel that referenced this issue Nov 22, 2023
@Luisav1
Add preferences model and structure for character sets. See phetsims/…
8f8c48e 
…area-model-multiplication#8 and phetsims/area-model-algebra#7.
Luisav1 added a commit to phetsims/babel that referenced this issue Nov 22, 2023
@Luisav1
Use strings from joist for region and culture. See phetsims/area-mode…
844f9a5 
…l-multiplication#8 and phetsims/area-model-algebra#7.
Luisav1 added a commit to phetsims/area-model-common that referenced this issue Nov 22, 2023
@Luisav1
Use strings from joist for region and culture. See phetsims/area-mode…
7d336df 
…l-multiplication#8 and phetsims/area-model-algebra#7.
Luisav1 added a commit that referenced this issue Nov 22, 2023
@Luisav1
Use strings from joist for region and culture. See #8 and phetsims/ar…
6e433b9 
…ea-model-algebra#7.
Luisav1 added a commit to phetsims/area-model-algebra that referenced this issue Nov 22, 2023
@Luisav1
Use strings from joist for region and culture. See phetsims/area-mode…
f3ef46c 
…l-multiplication#8 and #7.
amanda-phet added a commit to phetsims/area-model-common that referenced this issue Nov 30, 2023
@amanda-phet
Game screen icons for Area Model Multiplication
4ef3322 
phetsims/area-model-multiplication#8
amanda-phet added a commit to phetsims/area-model-common that referenced this issue Nov 30, 2023
@amanda-phet
Add files via upload
8dd9d61 
phetsims/area-model-multiplication#8
phetsims/area-model-algebra#7
@amanda-phet amanda-phet self-assigned this Dec 1, 2023
Luisav1 added a commit to phetsims/area-model-common that referenced this issue Dec 1, 2023
@Luisav1
Create regional folders and images directory. See phetsims/area-model…
d185a13 
…-multiplication#8.
Luisav1 added a commit that referenced this issue Dec 1, 2023
@Luisav1
Create regional folders and images directory. See #8.
559ba20
Luisav1 added a commit that referenced this issue Dec 1, 2023
@Luisav1
Move images to mipmaps folder. See #8.
f0d70f0
amanda-phet added a commit that referenced this issue Dec 1, 2023
@amanda-phet
Add files via upload
0021363 
#8
amanda-phet added a commit that referenced this issue Dec 1, 2023
@amanda-phet
Add files via upload
054d339 
#8
amanda-phet added a commit that referenced this issue Dec 1, 2023
@amanda-phet
Add files via upload
eb00fe0 
#8
amanda-phet added a commit that referenced this issue Dec 1, 2023
@amanda-phet
Add files via upload
5ed4290 
#8
amanda-phet added a commit that referenced this issue Dec 1, 2023
@amanda-phet
Add files via upload
7e15f9f 
#8
amanda-phet added a commit that referenced this issue Dec 1, 2023
@amanda-phet
Add files via upload
ef147fe 
#8
@amanda-phet
Copy link
Contributor

Artwork is all uploaded. Over to @Luisav1

@amanda-phet amanda-phet removed their assignment Dec 1, 2023
amanda-phet added a commit to phetsims/area-model-common that referenced this issue Dec 1, 2023
@amanda-phet
Updated game icons to include all regions
9918441 
phetsims/area-model-multiplication#8
phetsims/area-model-algebra#7
Luisav1 added a commit that referenced this issue Dec 4, 2023
@Luisav1
Update new icon licenses and create image js files. See #8.
1d86b3d
Luisav1 added a commit that referenced this issue Dec 5, 2023
@Luisav1
Rename africa-conservative directory to africa-modest See #8.
1acf9b1
Luisav1 added a commit that referenced this issue Dec 5, 2023
@Luisav1
Add Oceania, Asia, Latin America, Africa and Africa Modest character …
07b77e3 
…sets. Pass in character sets and jugglerController (character set controller) to the Multiplication game screen GenericGameScreen.js. See #8.
Luisav1 added a commit to phetsims/area-model-common that referenced this issue Dec 5, 2023
@Luisav1
Add Oceania, Asia, Latin America, Africa and Africa Modest character …
d550482 
…sets. Pass in character sets and jugglerController (character set controller) to the Multiplication game screen GenericGameScreen.js. See phetsims/area-model-multiplication#8.
Luisav1 added a commit to phetsims/area-model-common that referenced this issue Dec 5, 2023
@Luisav1
Remove unnecessary images and files no longer used. See phetsims/area…
e8889fa 
…-model-algebra#7 and phetsims/area-model-multiplication#8.
Luisav1 added a commit to phetsims/area-model-common that referenced this issue Dec 5, 2023
@Luisav1
Fix js doc. See phetsims/area-model-algebra#7 and phetsims/area-model…
f47a1a5 
…-multiplication#8.
Luisav1 added a commit that referenced this issue Dec 5, 2023
@Luisav1
Remove character set artwork duplicates. See #8.
4915654
Luisav1 added a commit that referenced this issue Dec 5, 2023
@Luisav1
Correct licenses for old files. See #8.
a06cc10
@Luisav1
Copy link
Contributor Author

Luisav1 commented Dec 5, 2023

The artwork is all integrated now. @amanda-phet could you review to ensure it's all good? Thanks!

@Luisav1 Luisav1 assigned amanda-phet and unassigned Luisav1 Dec 5, 2023
@amanda-phet
Copy link
Contributor

The icons looked good, but now we're replacing them with the svg images. Let me know when those are ready for review.

@amanda-phet amanda-phet assigned Luisav1 and unassigned amanda-phet Dec 8, 2023
Luisav1 added a commit that referenced this issue Dec 12, 2023
@Luisav1
Replace level icon node pngs with svgs. See #8.
5fb74e6
Luisav1 added a commit to phetsims/chipper that referenced this issue Dec 12, 2023
@Luisav1
Replace level icon node pngs with svgs. See phetsims/area-model-multi…
675eeed 
…plication#8.
amanda-phet added a commit that referenced this issue Dec 12, 2023
@amanda-phet
Add files via upload
2c5e0b7 
#8
amanda-phet added a commit that referenced this issue Dec 12, 2023
@amanda-phet
Add files via upload
dc84757 
#8
amanda-phet added a commit that referenced this issue Dec 12, 2023
@amanda-phet
Add files via upload
0ea10e2 
#8
amanda-phet added a commit that referenced this issue Dec 12, 2023
@amanda-phet
Add files via upload
e4c65a3 
#8
amanda-phet added a commit that referenced this issue Dec 12, 2023
@amanda-phet
Add files via upload
e77d1ef 
#8
amanda-phet added a commit that referenced this issue Dec 12, 2023
@amanda-phet
Add files via upload
4e9e620 
#8
@amanda-phet
Copy link
Contributor

SVG screen icons are now uploaded.

Luisav1 added a commit that referenced this issue Dec 13, 2023
@Luisav1
Replace home screen icon pngs with svgs. See #8.
9f10c02
@Luisav1
Copy link
Contributor Author

Luisav1 commented Dec 13, 2023

All the artwork is now replaced with the svg files. @amanda-phet sending this your way for your review.

@Luisav1 Luisav1 assigned amanda-phet and unassigned Luisav1 Dec 13, 2023
@amanda-phet
Copy link
Contributor

All of the artwork looks good to me!

samreid pushed a commit to phetsims/perennial that referenced this issue Oct 21, 2024
@Luisav1 @samreid
Replace level icon node pngs with svgs. See phetsims/area-model-multi…
3466c99 
…plication#8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amanda-phet amanda-phet

Labels
status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amanda-phet @Luisav1