error handling for getNextTestInfo (upon 500 axios error), #219

phetsims · Oct 30, 2024 · c2d270f · c2d270f
1 parent 155f552
commit c2d270f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/js/node-client/getNextTestInfo.js b/js/node-client/getNextTestInfo.js
@@ -23,17 +23,17 @@ module.exports = async function( options ) {
 
   }, options );
 
-  let response = {};
+  let response = null;
   try {
     response = await axios( `${options.serverURL}/aquaserver/next-test?old=${options.old}` );
   }
   catch( e ) {
     throw new Error( `axios failure code ${e.response.status} getting next-test: ${e.message}` );
   }
 
-  if ( response.status !== 200 ) {
+  if ( response?.status !== 200 ) {
     throw new Error( `nextTest request failed with status ${response.status} ${response}` );
   }
 
-  return response.data || {};
+  return response?.data || null;
 };
diff --git a/js/node-client/runNextTest.js b/js/node-client/runNextTest.js
@@ -32,9 +32,11 @@ module.exports = async function( options ) {
         testInfo = await getNextTestInfo( options );
         winston.info( 'testInfo', JSON.stringify( testInfo ) );
       }
-      await runTest( testInfo, options );
-      winston.debug( 'runTest completed' );
-      return;
+      if ( testInfo ) {
+        await runTest( testInfo, options );
+        winston.debug( 'runTest completed' );
+        return;
+      }
     }
     catch( e ) {
       lastFailure = e;