Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support more function arguments #114

Merged
merged 5 commits into from
Jan 28, 2025
Merged

Support more function arguments #114

merged 5 commits into from
Jan 28, 2025

Conversation

PgBiel
Copy link
Contributor

@PgBiel PgBiel commented Jan 28, 2025 •
edited
Loading

Future work

@PgBiel PgBiel mentioned this pull request Jan 28, 2025
Merged
@PgBiel PgBiel marked this pull request as ready for review January 28, 2025 21:55
@pherrymason
Copy link
Owner

Wasn't &self already working?

@PgBiel
Copy link
Contributor Author

PgBiel commented Jan 28, 2025 •
edited
Loading

Apparently not :)

The corresponding test was failing, and the stdlib types were missing the pointer *.

@pherrymason pherrymason merged commit 5d795f1 into pherrymason:main Jan 28, 2025
2 checks passed
@PgBiel PgBiel deleted the arg-improvements branch January 28, 2025 22:14
@PgBiel
Copy link
Contributor Author

PgBiel commented Jan 28, 2025

Hold on, there's a slight little bug with hover... submitting hotfix

@PgBiel PgBiel mentioned this pull request Jan 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hover does not show default arguments
2 participants
@PgBiel @pherrymason