Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for BDEWPayloadParams#m_aDocumentNumber #137

Merged
merged 2 commits into from
Jun 23, 2023
Merged

Fix for BDEWPayloadParams#m_aDocumentNumber #137

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c177dd
BDEWDocumentNo data type fixed (old: Integer, new: String)
mmwlk Jun 22, 2023
441c4b7
Merge branch 'phax:master' into master
mmwlk Jun 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions phase4-bdew-client/src/main/java/com/helger/phase4/bdew/Phase4BDEWSender.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ protected final void mainSendMessage () throws Phase4Exception
.toString ());
if (m_aPayloadParams.getDocumentNumber () != null)
aPayloadAttachment.customPartProperties ()
.put ("BDEWDocumentNo", m_aPayloadParams.getDocumentNumber ().toString ());
.put ("BDEWDocumentNo", m_aPayloadParams.getDocumentNumber ());
if (m_aPayloadParams.getFulfillmentDate () != null)
aPayloadAttachment.customPartProperties ()
.put ("BDEWFulfillmentDate",
Expand Down Expand Up @@ -301,7 +301,7 @@ public static class BDEWPayloadParams
{
private String m_sDocumentType;
private ZonedDateTime m_aDocumentDate;
private Integer m_aDocumentNumber;
private String m_aDocumentNumber;
private ZonedDateTime m_aFulfillmentDate;
private String m_sSubjectPartyID;
private String m_sSubjectPartyRole;
Expand Down Expand Up @@ -359,7 +359,7 @@ public BDEWPayloadParams setDocumentDate (@Nullable final ZonedDateTime sDocumen
* <code>BDEWDocumentNo</code>
*/
@Nullable
public Integer getDocumentNumber ()
public String getDocumentNumber ()
{
return m_aDocumentNumber;
}
Expand All @@ -386,7 +386,7 @@ public BDEWPayloadParams setDocumentNumber (final int nDocumentNumber)
* @return this for chaining
*/
@Nonnull
public BDEWPayloadParams setDocumentNumber (@Nullable final Integer aDocumentNumber)
public BDEWPayloadParams setDocumentNumber (@Nullable final String aDocumentNumber)
{
m_aDocumentNumber = aDocumentNumber;
return this;
Expand Down